Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6722)

Issue 100730044: utils/apt: new package

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by rog
Modified:
9 years, 11 months ago
Reviewers:
mp+220792, natefinch
Visibility:
Public.

Description

utils/apt: new package It makes sense on its own, and we want to remove the osenv dependency from utils. https://code.launchpad.net/~rogpeppe/juju-core/560-utils-apt/+merge/220792 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : utils/apt: new package #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -131 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M agent/mongo/mongo.go View 3 chunks +5 lines, -4 lines 0 comments Download
M cmd/jujud/machine_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M cmd/jujud/upgrade_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M container/kvm/initialisation.go View 3 chunks +3 lines, -2 lines 0 comments Download
M container/lxc/initialisation.go View 2 chunks +3 lines, -3 lines 0 comments Download
M container/lxc/initialisation_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 2 chunks +3 lines, -2 lines 0 comments Download
M provider/local/environprovider.go View 2 chunks +2 lines, -1 line 0 comments Download
M provider/local/environprovider_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M provider/local/prereqs.go View 2 chunks +2 lines, -1 line 0 comments Download
M provider/local/prereqs_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M upgrades/rsysloggnutls.go View 1 chunk +2 lines, -4 lines 0 comments Download
M utils/apt/apt.go View 7 chunks +37 lines, -46 lines 0 comments Download
M utils/apt/apt_test.go View 16 chunks +47 lines, -45 lines 0 comments Download
A utils/isubuntu.go View 1 chunk +14 lines, -0 lines 0 comments Download
A utils/isubuntu_test.go View 1 1 chunk +35 lines, -0 lines 0 comments Download
M worker/machineenvironmentworker/machineenvironmentworker.go View 2 chunks +3 lines, -2 lines 0 comments Download
M worker/machineenvironmentworker/machineenvironmentworker_test.go View 6 chunks +6 lines, -6 lines 0 comments Download
M worker/provisioner/container_initialisation_test.go View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
9 years, 11 months ago (2014-05-23 11:45:47 UTC) #1
natefinch
LGTM
9 years, 11 months ago (2014-05-23 11:56:04 UTC) #2
rog
9 years, 11 months ago (2014-05-23 12:00:53 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b