Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4546)

Issue 100700044: Make versions aware of alpha, beta, dev tags.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by thumper
Modified:
9 years, 11 months ago
Reviewers:
menn0, mp+220898, fwereade
Visibility:
Public.

Description

Make versions aware of alpha, beta, dev tags. Update the version number structure to have a tag. A development version is an odd minor before 1.19.3 or anything with a tag after that (or a non-zero build number). Using the following format: {major}.{minor}.{patch} # if tag empty and build 0 {major}.{minor}.{patch}.{build} # if tag empty {major}.{minor}-{tag}{patch} # if build 0 {major}.{minor}-{tag}{patch}.{build} This way any tag gets sorted before a release using deb version sort. I don't care and the code doesn't check about alpha/beta vs. dev tags, but sorts them lexically. https://code.launchpad.net/~thumper/juju-core/enable-alpha-versions/+merge/220898 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Make versions aware of alpha, beta, dev tags. #

Total comments: 4

Patch Set 3 : Make versions aware of alpha, beta, dev tags. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -56 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/upgradejuju_test.go View 1 2 chunks +9 lines, -9 lines 0 comments Download
M cmd/supercommand_test.go View 1 chunk +1 line, -5 lines 0 comments Download
M environs/bootstrap/bootstrap_test.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M environs/testing/tools.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M version/version.go View 1 2 8 chunks +49 lines, -25 lines 0 comments Download
M version/version_test.go View 1 2 4 chunks +56 lines, -13 lines 0 comments Download

Messages

Total messages: 5
thumper
Please take a look.
9 years, 11 months ago (2014-05-26 04:49:12 UTC) #1
menn0
LGTM.
9 years, 11 months ago (2014-05-26 05:40:05 UTC) #2
thumper
Please take a look.
9 years, 11 months ago (2014-05-26 06:17:36 UTC) #3
fwereade
LGTM, just trivials https://codereview.appspot.com/100700044/diff/20001/environs/testing/tools.go File environs/testing/tools.go (right): https://codereview.appspot.com/100700044/diff/20001/environs/testing/tools.go#newcode299 environs/testing/tools.go:299: V3101qppc64 = version.MustParseBinary("3.1-dev0.1-quantal-ppc64") v31d0...? https://codereview.appspot.com/100700044/diff/20001/version/version.go File ...
9 years, 11 months ago (2014-05-26 07:07:57 UTC) #4
thumper
9 years, 11 months ago (2014-05-27 01:39:22 UTC) #5
Please take a look.

https://codereview.appspot.com/100700044/diff/20001/environs/testing/tools.go
File environs/testing/tools.go (right):

https://codereview.appspot.com/100700044/diff/20001/environs/testing/tools.go...
environs/testing/tools.go:299: V3101qppc64 =
version.MustParseBinary("3.1-dev0.1-quantal-ppc64")
On 2014/05/26 07:07:56, fwereade wrote:
> v31d0...?

Done.

https://codereview.appspot.com/100700044/diff/20001/version/version.go
File version/version.go (right):

https://codereview.appspot.com/100700044/diff/20001/version/version.go#newcode72
version/version.go:72: Tag   string
On 2014/05/26 07:07:56, fwereade wrote:
> Tag before Patch?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b