Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2988)

Issue 100580045: Fix build error with Go 1.3

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by dfc
Modified:
9 years, 10 months ago
Reviewers:
axw, mp+220145, hduran
Visibility:
Public.

Description

Fix build error with Go 1.3 A change that landed in Go 1.3 was an additional restriction that you could not `go install` a package if there was no source to install. Prior to this the results of doing `go install launchpad.net/juju-core` were in consistent. If you did `go install launchpad.net/juju-core/...` then the base package would fail to build, but all the sub packages would build. In Go < 1.3 this was a warning. This failure is not an error and the whole `go install` command will return exit 1. To fix this, as well as have a nice high level description that shows up in godoc.org, add a small file at the top level so it can be built (ie, a .a file is generated) which keeps the tool happy. It is worth noting that our hacked version of the Go 1.2 build tool for ppc64el also suffers from this limitation as it is a mash up of bits of Go 1.2 and Go 1.3's build tool. nb. Why is there no source to install ? Because the only files in that directory end in _test.go; they are test source, not package source, and test source is never installed. https://code.launchpad.net/~dave-cheney/juju-core/177-fix-build-error/+merge/220145 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix build error with Go 1.3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
A doc.go View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dfc
Please take a look.
9 years, 10 months ago (2014-05-20 01:50:34 UTC) #1
axw
On 2014/05/20 01:50:34, dfc wrote: > Please take a look. LGTM, though I think it'd ...
9 years, 10 months ago (2014-05-20 01:54:32 UTC) #2
dfc
Please take a look.
9 years, 10 months ago (2014-05-20 01:57:34 UTC) #3
hduran
On 2014/05/20 01:57:34, dfc wrote: > Please take a look. LGTM, perhaps the description for ...
9 years, 10 months ago (2014-05-20 02:37:26 UTC) #4
dfc
9 years, 10 months ago (2014-05-20 03:17:01 UTC) #5
Nah, I think the commit log is sufficient.

On Tue, May 20, 2014 at 12:37 PM,  <horacio.duran@canonical.com> wrote:
> On 2014/05/20 01:57:34, dfc wrote:
>>
>> Please take a look.
>
>
> LGTM, perhaps the description for this patch should be included in the
> /doc folder?
>
> https://codereview.appspot.com/100580045/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b