Issue 230910043: Fixing a couple bugs in the client codelab.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 230910043: Fixing a couple bugs in the client codelab. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by shaza

Modified:
9 years ago

Reviewers:
kathyw

Base URL:
https://github.com/dart-lang/dartlang.org.git@master

Visibility:
Public.

More Reviews

Description

Fixing a couple bugs in the client codelab. BUG= Committed: 893260fb35411aec43501249d8d668434da9d1e9

Patch Set 2 : #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/site/codelabs/darrrt/index.markdown	View	1	3 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

shaza

PTAL: https://darrt-dot-dart-lang.appspot.com/codelabs/darrrt/ (I'd like to get this out before I have to do some larger ...

9 years ago (2015-04-17 18:38:57 UTC) #1

kathyw

Looks fine, although I had a couple of quibbles https://codereview.appspot.com/230910043/diff/1/src/site/codelabs/darrrt/index.markdown File src/site/codelabs/darrrt/index.markdown (right): https://codereview.appspot.com/230910043/diff/1/src/site/codelabs/darrrt/index.markdown#newcode1795 src/site/codelabs/darrrt/index.markdown:1795: ...

9 years ago (2015-04-17 19:56:22 UTC) #2

shaza

Committed patchset #2 (id:20001) manually as 893260f (presubmit successful).

9 years ago (2015-04-17 20:44:01 UTC) #3

shaza

9 years ago (2015-04-17 20:44:19 UTC) #4

Message was sent while issue was closed.

Closing out.

https://codereview.appspot.com/230910043/diff/1/src/site/codelabs/darrrt/inde...
File src/site/codelabs/darrrt/index.markdown (right):

https://codereview.appspot.com/230910043/diff/1/src/site/codelabs/darrrt/inde...
src/site/codelabs/darrrt/index.markdown:1795: a Future or leave it
blank&mdash;the compiler then assumes
On 2015/04/17 19:56:21, kathyw wrote:
> I'm not sure it's the compiler that does the assuming, but it's unnecessary to
> say so anyway. How about:
> 
> Asynchronous functions must return a Future,
> so you can either specify a Future return type or leave it blank.

Done.

https://codereview.appspot.com/230910043/diff/1/src/site/codelabs/darrrt/inde...
src/site/codelabs/darrrt/index.markdown:1948: then select **Tools > Pub Build -
Minified**,
On 2015/04/17 19:56:21, kathyw wrote:
> Did you check whether that changes the output (shown below) at all?

Yes. This will be changing substantially after we push the new codelab.

Expand All Messages | Collapse All Messages