Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1043)

Issue 99980043: LIB: Add StartupException and subclasses. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by Brett
Modified:
9 years, 12 months ago
Reviewers:
pjo
CC:
connector-cr_google.com
Visibility:
Public.

Description

This change adds StartupException, and subclasses InvalidConfigurationException, and UnsupportedPlatformException. StartupExeceptions can be thrown by the Adaptor.init() method to immediatly abort Application startup. StartupExceptions bypass the Application retry with back-off wait recovery mechanism that will re-attempt to start the adaptor in hopes that a recoverable error has been corrected. Therefore StartupExceptions should be thrown for unrecoverable situations, such as running on the wrong platform or a configuration that could never be valid.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add call to Application.stop() in case of StartupException. I strongly suspect IOException should … #

Patch Set 3 : Call Application.stop() for all abnormal terminations. #

Patch Set 4 : Remove override of Exception.getMessage() #

Total comments: 2

Patch Set 5 : Remove override of Exception.getMessage() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -11 lines) Patch
M src/com/google/enterprise/adaptor/Application.java View 1 2 4 chunks +30 lines, -10 lines 0 comments Download
A src/com/google/enterprise/adaptor/InvalidConfigurationException.java View 1 2 3 4 1 chunk +52 lines, -0 lines 0 comments Download
A src/com/google/enterprise/adaptor/StartupException.java View 1 2 3 1 chunk +53 lines, -0 lines 0 comments Download
A src/com/google/enterprise/adaptor/UnsupportedPlatformException.java View 1 chunk +38 lines, -0 lines 0 comments Download
M test/com/google/enterprise/adaptor/ApplicationTest.java View 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 14
Brett
10 years ago (2014-05-01 00:22:46 UTC) #1
pjo
Thank you. Please make sure to run the code (say with `ant run' and modified ...
10 years ago (2014-05-01 00:57:58 UTC) #2
Brett
>Please make sure to run the code (say with >`ant run' and modified AdaptorTemplate to ...
10 years ago (2014-05-01 03:47:51 UTC) #3
Brett
Add call to Application.stop() in case of StartupException. I strongly suspect IOException should do the ...
10 years ago (2014-05-01 05:00:48 UTC) #4
Brett
Call Application.stop() for all abnormal terminations.
10 years ago (2014-05-02 00:18:34 UTC) #5
pjo
FYI: I'll prolly not look at this CL before Monday. Thank you. Can you also ...
10 years ago (2014-05-02 01:35:54 UTC) #6
Brett
Remove override of Exception.getMessage()
10 years ago (2014-05-02 02:43:43 UTC) #7
brett.michael.johnson_gmail.com
On May 1, 2014, at 6:35 PM, PJ <pjo@google.com> wrote: > FYI: I'll prolly not ...
10 years ago (2014-05-02 02:44:47 UTC) #8
pjo
1 other quick comment. Thank you https://codereview.appspot.com/99980043/diff/60001/src/com/google/enterprise/adaptor/InvalidConfigurationException.java File src/com/google/enterprise/adaptor/InvalidConfigurationException.java (right): https://codereview.appspot.com/99980043/diff/60001/src/com/google/enterprise/adaptor/InvalidConfigurationException.java#newcode61 src/com/google/enterprise/adaptor/InvalidConfigurationException.java:61: super(null, rootCause); remove ...
10 years ago (2014-05-02 02:49:03 UTC) #9
Brett
Remove override of Exception.getMessage()
10 years ago (2014-05-02 02:57:40 UTC) #10
Brett
https://codereview.appspot.com/99980043/diff/60001/src/com/google/enterprise/adaptor/InvalidConfigurationException.java File src/com/google/enterprise/adaptor/InvalidConfigurationException.java (right): https://codereview.appspot.com/99980043/diff/60001/src/com/google/enterprise/adaptor/InvalidConfigurationException.java#newcode61 src/com/google/enterprise/adaptor/InvalidConfigurationException.java:61: super(null, rootCause); On 2014/05/02 02:49:03, pjo wrote: > remove ...
10 years ago (2014-05-02 02:59:23 UTC) #11
pjo
LGTM. Thank you
10 years ago (2014-05-06 00:43:31 UTC) #12
pjo
Please submit. Thank you, PJ - technology's compounding interest - On Mon, May 5, 2014 ...
9 years, 12 months ago (2014-05-07 00:14:01 UTC) #13
Brett
9 years, 12 months ago (2014-05-07 00:33:43 UTC) #14
Committed 06 May 2014 to Adaptor Library:
To https://code.google.com/p/plexi/
   8b19c07..97c617d  master -> master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b