Issue 994041: Removed unnecessary include paths. Removed the dependency on unistd.h. Moved ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 994041: Removed unnecessary include paths. Removed the dependency on unistd.h. Moved ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 7 months ago by Alok Priyadarshi

Modified:
14 years, 7 months ago

Reviewers:
kbr1, kbr, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Removed unnecessary include paths. Removed the dependency on unistd.h. Moved the generated files to intermediate directory so that the source is not polluted. These changes only affect the gyp build system because they required flex-bison options that are not supported by old binaries in compiler/tools. Another reason to switch to gyp build system.

Patch Set 1 #

Created: 14 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -12 lines)			Patch
	M	src/build_angle.gyp	View		8 chunks	+7 lines, -11 lines	0 comments	Download
	M	src/compiler/glslang.l	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dgkoch

.. or at least upgrade to new flex/bison :-) no issues here.

14 years, 7 months ago (2010-04-23 17:03:31 UTC) #2

LGTM

Expand All Messages | Collapse All Messages