Fix inline event handlers on IE.

domita.js exposes plugin_dispatchEvent___ through which all UI events are routed to handlers in untrusted HTML.

Changed the way TemplateCompiler hooks inline event handlers into HTML.  Now instead of hanging these handlers from IMPORTS___, they are instead declared in the module scope, and events are attached via (el___.onclick = ...) instead of htmlEmitter___.setAttr(...).

These changes required fixing some problems in the synthetic checks in cajita and valija rewriters.  Both had duplicate rules that handled synthetic nodes, but those rules were buggy and had diverged.  I moved those rules to a common place, and fixed the synthetic function rule to create a scope to properly handle synthetic functions with formal parameters, and to allow synthetic formal parameters.


Submitted @3648

[MikeSamuel, 2009-08-05 00:03:12]

http://codereview.appspot.com/99060/diff/1/12
File src/com/google/caja/parser/quasiliteral/SyntheticRuleSet.java (right):

http://codereview.appspot.com/99060/diff/1/12#newcode57
Line 57: return rw.noexpand((Reference) node);
This bit was missing from one of the two.

http://codereview.appspot.com/99060/diff/1/12#newcode83
Line 83: },
This rule is new.

http://codereview.appspot.com/99060/diff/1/12#newcode211
Line 211: },
This rule is new.

http://codereview.appspot.com/99060/diff/1/12#newcode228
Line 228: Scope newScope = Scope.fromFunctionConstructor(scope, ctor);
This scope handling code is new.

[Jasvir, 2009-08-07 01:49:53]

LGTM

http://codereview.appspot.com/99060/diff/1/12
File src/com/google/caja/parser/quasiliteral/SyntheticRuleSet.java (right):

http://codereview.appspot.com/99060/diff/1/12#newcode1
Line 1: // Copyright (C) 2009 Google Inc.
Thanks for refactoring out synthetic node handling.  Can you add tests for these
rules please?

[MikeSamuel, 2009-08-07 04:45:31]

http://codereview.appspot.com/99060/diff/1/12
File src/com/google/caja/parser/quasiliteral/SyntheticRuleSet.java (right):

http://codereview.appspot.com/99060/diff/1/12#newcode1
Line 1: // Copyright (C) 2009 Google Inc.
On 2009/08/07 01:49:55, jasvir wrote:
> Thanks for refactoring out synthetic node handling.  Can you add tests for
these
> rules please?

Should I move the tests at
http://code.google.com/p/google-caja/source/browse/trunk/tests/com/google/caj...
into CommonJsRewriterTestCase and add ones for the new rules?

[MikeSamuel, 2009-08-07 21:37:16]

Added tests.

On 2009/08/07 04:45:31, MikeSamuel wrote:
> http://codereview.appspot.com/99060/diff/1/12
> File src/com/google/caja/parser/quasiliteral/SyntheticRuleSet.java (right):
> 
> http://codereview.appspot.com/99060/diff/1/12#newcode1
> Line 1: // Copyright (C) 2009 Google Inc.
> On 2009/08/07 01:49:55, jasvir wrote:
> > Thanks for refactoring out synthetic node handling.  Can you add tests for
> these
> > rules please?
> 
> Should I move the tests at
>
http://code.google.com/p/google-caja/source/browse/trunk/tests/com/google/caj...
> into CommonJsRewriterTestCase and add ones for the new rules?