Issue 99043: Fix compile error due to string literal overflow on large proto files.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 99043: Fix compile error due to string literal overflow on large proto files.

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by kenton

Modified:
14 years, 8 months ago

Reviewers:
eric.perie

CC:
protobuf_googlegroups.com

Base URL:
http://protobuf.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Hi Eric, I decided to do this patch a little differently -- in particular, I moved the actual string concatenation to occur in Descriptors.java rather than in generated code. I also added a test. At Google we have a policy of reviewing all changes before submission, so can you take a look and tell me if this code looks good to you?

Patch Set 1 #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1078 lines, -5 lines)			Patch
M	java/pom.xml	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	java/src/main/java/com/google/protobuf/Descriptors.java	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	java/src/test/java/com/google/protobuf/DescriptorsTest.java	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/Makefile.am	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/google/protobuf/compiler/java/java_file.cc	View	1 chunk	+11 lines, -3 lines	0 comments	Download
A	src/google/protobuf/unittest_enormous_descriptor.proto	View	1 chunk	+1045 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

eric.perie

14 years, 8 months ago (2009-08-17 18:40:36 UTC) #2

On 2009/08/03 22:53:24, kenton wrote:
> 
Hello Kenton, I am back from vacation, and applied your patch to
protobuf 2.10.

I got the following compilation error:

internalBuildGeneratedFileFrom(java.lang.String,com.google.protobuf.Descriptors.FileDescriptor[],com.google.protobuf.Descriptors.FileDescriptor.InternalDescriptorAssigner)
in com.google.protobuf.Descriptors.FileDescriptor cannot be applied to
(java.lang.String[],com.google.protobuf.Descriptors.FileDescriptor[],com.google.protobuf.Descriptors.FileDescriptor.InternalDescriptorAssigner)
      .internalBuildGeneratedFileFrom(descriptorData,
      ^

Expand All Messages | Collapse All Messages