Issue 989043: test binaries are in the builddir, not the top_srcdir

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 989043: test binaries are in the builddir, not the top_srcdir (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Pierre Phaneuf (Google)

Modified:
14 years ago

Reviewers:
hamaji, shinichiro.hamaji, jeffbailey

Base URL:
http://google-glog.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This is so you can build and run tests out-of-tree ("svn co ... glog && mkdir build && cd build && ../glog/configure && make && make check"). Unfortunately, it's not enough, seems some tests are relying on FLAGS_test_srcdir (which, somehow, should be set to either $(srcdir) or $(top_srcdir), I think?). This only gets it going a bit further, only to fail on those other issues, but it's a step in the right direction...

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Makefile.am	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Pierre Phaneuf (Google)

We're using glog in http://dnproxy.googlecode.com/, and we build out-of-tree all the time, noticed that "make ...

14 years ago (2010-04-27 19:35:38 UTC) #1

Pierre Phaneuf (Google)

Ping? I actually can't submit this myself, hamaji has to do it... Thanks!

14 years ago (2010-05-14 19:13:54 UTC) #3

shinichiro.hamaji

14 years ago (2010-05-14 21:47:20 UTC) #4

On 2010/05/14 19:13:54, pphaneuf-google wrote:
> Ping? I actually can't submit this myself, hamaji has to do it...
> 
> Thanks!

Sorry for the big latency. I've somehow missed this.

Committed in: http://code.google.com/p/google-glog/source/detail?r=77

Expand All Messages | Collapse All Messages