Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1929)

Issue 982044: code review 982044: Freetype-Go: Add Luxi .ttf fonts, and the human-readabl... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by nigeltao
Modified:
14 years, 8 months ago
Reviewers:
r, rsc
CC:
golang-dev
Visibility:
Public.

Description

Freetype-Go: Add Luxi .ttf fonts, and the human-readable .ttx equivalents. All up this is about 10 MiB of data, about 90% of which is the .ttx XML versions.

Patch Set 1 #

Patch Set 2 : code review 982044: Freetype-Go: Add Luxi .ttf fonts, and the human-readabl... #

Patch Set 3 : code review 982044: Freetype-Go: Add Luxi .ttf fonts, and the human-readabl... #

Patch Set 4 : code review 982044: Freetype-Go: Add Luxi .ttf fonts, and the human-readabl... #

Patch Set 5 : code review 982044: Freetype-Go: Add Luxi .ttf fonts, and the human-readabl... #

Patch Set 6 : code review 982044: Freetype-Go: Add Luxi .ttf fonts, and the human-readabl... #

Patch Set 7 : code review 982044: Freetype-Go: Add Luxi .ttf fonts, and the human-readabl... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47176 lines, -0 lines) Patch
M LICENSE View 1 chunk +3 lines, -0 lines 0 comments Download
A luxi-fonts/COPYING View 1 chunk +42 lines, -0 lines 0 comments Download
A luxi-fonts/README View 1 chunk +12 lines, -0 lines 0 comments Download
A luxi-fonts/luximr.ttf View Binary file 0 comments Download
A luxi-fonts/luximr.ttx View 1 chunk +24616 lines, -0 lines 0 comments Download
A luxi-fonts/luxirr.ttf View Binary file 0 comments Download
A luxi-fonts/luxisr.ttf View Binary file 0 comments Download
A luxi-fonts/luxisr.ttx View 1 chunk +22503 lines, -0 lines 0 comments Download

Messages

Total messages: 7
nigeltao
Hello r, rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 8 months ago (2010-04-27 12:30:04 UTC) #1
r
LGTM but rsc understands the licensing issues better so wait for him.
14 years, 8 months ago (2010-04-27 16:35:02 UTC) #2
rsc
LGTM What do you plan to use the ttx for? Is it worth having both ...
14 years, 8 months ago (2010-04-27 17:08:58 UTC) #3
nigeltao_gnome
On 28 April 2010 03:08, Russ Cox <rsc@golang.org> wrote: > What do you plan to ...
14 years, 8 months ago (2010-04-27 23:25:09 UTC) #4
rsc
LGTM On Tue, Apr 27, 2010 at 16:25, Nigel Tao <nigel.tao.gnome@gmail.com> wrote: > On 28 ...
14 years, 8 months ago (2010-04-27 23:45:14 UTC) #5
nigeltao
*** Abandoned ***
14 years, 8 months ago (2010-04-28 12:29:47 UTC) #6
nigeltao_gnome
14 years, 8 months ago (2010-04-28 12:32:10 UTC) #7
On 28 April 2010 22:29,  <nigeltao@golang.org> wrote:
> *** Abandoned ***
>
> http://codereview.appspot.com/982044/show

I think this change was too large for the codereview extension to
handle, even after I trimmed it down from 12 fonts to 3, so I hg
pushed it manually.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b