Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1171)

Issue 98057: r291 added support for building on platforms where subpixel support

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by agl
Modified:
15 years, 4 months ago
Reviewers:
evan
Visibility:
Public.

Description

r291 added support for building on platforms where subpixel support has been compiled out of FreeType. However, it turns out that there is a common situation in which we build on platforms with subpixel support, but have to run without it: people downloading Chromium from the buildbots. Because we this, we need a runtime solution. Modifying the conversion routines for this seems suboptimal because the extra branches will slow down everyone. So we probe subpixel support at runtime by trying to install a low-pass filter. If we fail at this, then we map all the SkScalerContext::Rec structures to remove subpixel mode.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 3 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2
agl
15 years, 4 months ago (2009-07-28 18:26:45 UTC) #1
evan
15 years, 4 months ago (2009-07-28 18:35:18 UTC) #2
LGTM

Might wanna make the first line of hte review better
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b