Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3712)

Issue 97510043: Use built-in make functions for finding absolute paths. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by hanwenn
Modified:
9 years, 11 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Use built-in make functions for finding absolute paths.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M stepmake/stepmake/generic-vars.make View 3 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 5
hanwenn
please review.
9 years, 11 months ago (2014-05-16 09:05:23 UTC) #1
hanwenn
david, can you have a look?
9 years, 11 months ago (2014-05-17 13:21:19 UTC) #2
dak
On 2014/05/17 13:21:19, hanwenn wrote: > david, can you have a look? Well, I checked ...
9 years, 11 months ago (2014-05-17 15:54:25 UTC) #3
hanwenn
On 2014/05/17 15:54:25, dak wrote: > On 2014/05/17 13:21:19, hanwenn wrote: > > david, can ...
9 years, 11 months ago (2014-05-18 12:15:56 UTC) #4
dak
9 years, 11 months ago (2014-05-18 12:33:25 UTC) #5
On 2014/05/18 12:15:56, hanwenn wrote:
> On 2014/05/17 15:54:25, dak wrote:
> > On 2014/05/17 13:21:19, hanwenn wrote:
> > > david, can you have a look?
> > 
> > Well, I checked that the function used (realpath) has been present in GNU
make
> > since something like 2006.  So we should be basically fine, but Windows path
> > names are always a dare anyway and I don't have a Windows system available
> > myself.
> > 
> > So I don't see much of an option rather than letting this cook in the next
> > unstable version release and see whether GUB makes it to the finishing line.
> 
> Does GUB actually run on Windows? I wasn't aware of that.
> 
> We could workaround by interposing a function that does something different on
> windows.

Well, regarding GUB my experience is pretty much hearsay.  After thinking about
it, you are probably right that it never runs on the target system itself.  I
mean, that's sort of its point.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b