Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(326)

Issue 975044: PYSON doc (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by udono
Modified:
10 years, 8 months ago
Reviewers:
ced, yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 24

Patch Set 2 : Divide PYSON doc into ref and topic chapters #

Total comments: 20

Patch Set 3 : Add topics/pyson example content #

Total comments: 26

Patch Set 4 : New Patch #

Patch Set 5 : Some more minor changes. #

Total comments: 29

Patch Set 6 : Overwork doc #

Patch Set 7 : Fix headings #

Total comments: 28

Patch Set 8 : Please check for Not() if it follows the pattern... #

Total comments: 22

Patch Set 9 : add last suggestions #

Total comments: 20

Patch Set 10 : next versions #

Total comments: 5

Patch Set 11 : fix last issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+354 lines, -0 lines) Patch
A doc/ref/pyson.rst View 2 6 7 8 9 10 1 chunk +250 lines, -0 lines 0 comments Download
A doc/topics/pyson.rst View 1 2 3 4 5 6 7 8 9 10 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 25
ced
http://codereview.appspot.com/975044/diff/1/2 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/1/2#newcode7 doc/topics/pyson.rst:7: Pyson is a domain specific language (DSL_) to parse ...
13 years, 11 months ago (2010-04-27 17:43:52 UTC) #1
udono
http://codereview.appspot.com/975044/diff/1/2 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/1/2#newcode54 doc/topics/pyson.rst:54: Returns a JSON dictionary with key ``'__class__'`` with value ...
13 years, 11 months ago (2010-04-27 17:51:10 UTC) #2
ced
http://codereview.appspot.com/975044/diff/1/2 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/1/2#newcode54 doc/topics/pyson.rst:54: Returns a JSON dictionary with key ``'__class__'`` with value ...
13 years, 11 months ago (2010-04-27 17:56:32 UTC) #3
yangoon1
13 years, 11 months ago (2010-04-27 18:58:13 UTC) #4
udono
http://codereview.appspot.com/975044/diff/1/2 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/1/2#newcode54 doc/topics/pyson.rst:54: Returns a JSON dictionary with key ``'__class__'`` with value ...
13 years, 11 months ago (2010-04-27 18:58:59 UTC) #5
ced
http://codereview.appspot.com/975044/diff/1/2 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/1/2#newcode54 doc/topics/pyson.rst:54: Returns a JSON dictionary with key ``'__class__'`` with value ...
13 years, 11 months ago (2010-04-27 19:20:44 UTC) #6
udono
Done all corrections and suggestions. Please review Patch set 2. Thanks Udo http://codereview.appspot.com/975044/diff/1/2 File doc/topics/pyson.rst ...
13 years, 11 months ago (2010-04-27 22:13:41 UTC) #7
ced
http://codereview.appspot.com/975044/diff/7001/8001 File doc/ref/pyson.rst (right): http://codereview.appspot.com/975044/diff/7001/8001#newcode1 doc/ref/pyson.rst:1: .. _ref-pyson: .. module:: trytond.pyson http://codereview.appspot.com/975044/diff/7001/8001#newcode7 doc/ref/pyson.rst:7: .. class:: ...
13 years, 11 months ago (2010-04-27 22:27:58 UTC) #8
udono
Hi, I have uploaded the overworked topics/pyson.rst, including the provided ideas and corrections. Thanks a ...
13 years, 11 months ago (2010-04-28 14:21:39 UTC) #9
ced
http://codereview.appspot.com/975044/diff/15001/16001 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/15001/16001#newcode7 doc/topics/pyson.rst:7: PYSON is the *PY* thon *S* tatement and *O* ...
13 years, 11 months ago (2010-04-28 18:11:18 UTC) #10
udono
New patch uploaded. Please review. http://codereview.appspot.com/975044/diff/15001/16001 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/15001/16001#newcode7 doc/topics/pyson.rst:7: PYSON is the *PY* ...
13 years, 11 months ago (2010-04-29 10:44:58 UTC) #11
ced
http://codereview.appspot.com/975044/diff/18002/19001 File doc/ref/models/pyson.rst (right): http://codereview.appspot.com/975044/diff/18002/19001#newcode1 doc/ref/models/pyson.rst:1: .. _ref-models-pyson: not in models http://codereview.appspot.com/975044/diff/18002/19001#newcode10 doc/ref/models/pyson.rst:10: How to ...
13 years, 11 months ago (2010-04-29 18:50:21 UTC) #12
udono
http://codereview.appspot.com/975044/diff/18002/19001 File doc/ref/models/pyson.rst (right): http://codereview.appspot.com/975044/diff/18002/19001#newcode1 doc/ref/models/pyson.rst:1: .. _ref-models-pyson: On 2010/04/29 18:50:22, ced wrote: > not ...
13 years, 11 months ago (2010-04-30 17:16:44 UTC) #13
ced
http://codereview.appspot.com/975044/diff/18002/19002 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/18002/19002#newcode23 doc/topics/pyson.rst:23: On 2010/04/30 17:16:45, udono wrote: > On 2010/04/29 18:50:22, ...
13 years, 11 months ago (2010-04-30 17:36:58 UTC) #14
ced
http://codereview.appspot.com/975044/diff/21002/25001 File doc/ref/pyson.rst (right): http://codereview.appspot.com/975044/diff/21002/25001#newcode19 doc/ref/pyson.rst:19: Method that returns the dictionary representation of the statement. ...
13 years, 11 months ago (2010-05-02 08:02:25 UTC) #15
ced
http://codereview.appspot.com/975044/diff/21002/25002 File doc/topics/pyson.rst (right): http://codereview.appspot.com/975044/diff/21002/25002#newcode7 doc/topics/pyson.rst:7: PYSON is the Python statement and object notation. It ...
13 years, 11 months ago (2010-05-02 08:09:11 UTC) #16
udono
Fix all issues, but having some questions... Please review. Thanks! http://codereview.appspot.com/975044/diff/21002/25001 File doc/ref/pyson.rst (right): http://codereview.appspot.com/975044/diff/21002/25001#newcode19 ...
13 years, 11 months ago (2010-05-02 08:51:13 UTC) #17
yangoon1
Thx! You only write about PYSONEncoder, nothing about Decoder, is this by design? http://codereview.appspot.com/975044/diff/31001/32001 File ...
13 years, 11 months ago (2010-05-03 10:00:57 UTC) #18
udono
13 years, 11 months ago (2010-05-03 17:13:30 UTC) #19
udono
Thanks for review. http://codereview.appspot.com/975044/diff/31001/32001 File doc/ref/pyson.rst (right): http://codereview.appspot.com/975044/diff/31001/32001#newcode316 doc/ref/pyson.rst:316: :attr:`day` are defaulted from datetime.date.today(). On ...
13 years, 11 months ago (2010-05-03 17:13:45 UTC) #20
ced
http://codereview.appspot.com/975044/diff/31001/32001 File doc/ref/pyson.rst (right): http://codereview.appspot.com/975044/diff/31001/32001#newcode77 doc/ref/pyson.rst:77: --- On 2010/05/02 08:51:13, udono wrote: > ``value`` can ...
13 years, 11 months ago (2010-05-03 18:28:39 UTC) #21
udono
13 years, 11 months ago (2010-05-04 12:05:11 UTC) #22
udono
@yangoon: > You only write about PYSONEncoder, nothing about Decoder, > is this by design? ...
13 years, 11 months ago (2010-05-04 12:05:16 UTC) #23
ced
http://codereview.appspot.com/975044/diff/42001/43001 File doc/ref/pyson.rst (right): http://codereview.appspot.com/975044/diff/42001/43001#newcode41 doc/ref/pyson.rst:41: Encoder for PYSON statements into string representations. In other ...
13 years, 11 months ago (2010-05-04 21:07:35 UTC) #24
udono
13 years, 11 months ago (2010-05-05 21:13:20 UTC) #25

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b