Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(207)

Issue 975: Add support for removes in updater.py and update-client.py

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by noe
Modified:
2 months, 1 week ago
Reviewers:
Panayiotis
SVN Base:
http://malfind2.googlecode.com/svn/trunk/

Patch Set 1

Total comments: 5
Raw unified diffs Stats Side-by-side diffs with inline comments Delta from patch set
index.yaml 1 chunk 13 lines 0 comments
update-client.py 3 chunks 77 lines 0 comments
updater.py 2 chunks 55 lines 5 comments

Messages

Total messages: 1
Panayiotis
2 months, 1 week ago
http://codereview.appspot.com/975/diff/1/4
File updater.py (right):

http://codereview.appspot.com/975/diff/1/4#newcode1
Line 1: import logging
move all these changes to display/handler_update.py :) 

(you may need to svn up)

http://codereview.appspot.com/975/diff/1/4#newcode22
Line 22: for m in re.finditer('([+-])([a-zA-Z0-9]{32})', data):
a-fA-F

also lowercase before adding / looking up

http://codereview.appspot.com/975/diff/1/4#newcode23
Line 23: op, hash = m.group(1), m.group(2)
what if this doesn't match? let's log and continue.

http://codereview.appspot.com/975/diff/1/4#newcode24
Line 24: digest = Digest.gql('WHERE hash = :1', hash).get()
name this digests, and instead of get() do get(100) (see the API I think that's
how you get all matches).

http://codereview.appspot.com/975/diff/1/4#newcode30
Line 30: del_count += 1
else logging.warning ...
Sign in to reply to this message.

Powered by Google App Engine
This is Rietveld r168