Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1)

Issue 97119: Rewrite the vertical layout of staves/systems. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by joeneeman
Modified:
8 years, 1 month ago
Reviewers:
Patrick McCarty
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Rewrite the vertical layout of staves/systems. This combines the positioning of systems and staves into a single pass of a rod-and-spring problem. As a consequence, the spacing of staves within a system is much more configurable. Most properties related to vertical spacing have been removed (eg. page-top-space, between-system-space, between-system-padding) and replaced with more powerful versions (eg. first-system-spacing, first-system-title-spacing, between-system-spacing). FIXME: annotate-spacing is broken

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1343 lines, -1047 lines) Patch
M input/regression/alignment-vertical-manual-setting.ly View 2 chunks +5 lines, -5 lines 0 comments Download
M input/regression/page-layout-twopass.ly View 1 chunk +0 lines, -32 lines 0 comments Download
A input/regression/page-spacing-bottom-spring.ly View 1 chunk +20 lines, -0 lines 0 comments Download
A input/regression/page-spacing-first-system-spacing.ly View 1 chunk +19 lines, -0 lines 0 comments Download
A input/regression/page-spacing-first-system-title-spacing.ly View 1 chunk +19 lines, -0 lines 0 comments Download
A input/regression/page-spacing-staff-group.ly View 1 chunk +30 lines, -0 lines 0 comments Download
A input/regression/page-spacing-stretchability.ly View 1 chunk +19 lines, -0 lines 0 comments Download
M lily/align-interface.cc View 11 chunks +40 lines, -161 lines 0 comments Download
M lily/axis-group-interface.cc View 3 chunks +28 lines, -18 lines 0 comments Download
M lily/constrained-breaking.cc View 2 chunks +15 lines, -5 lines 0 comments Download
M lily/include/align-interface.hh View 1 chunk +7 lines, -9 lines 0 comments Download
M lily/include/axis-group-interface.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/page-breaking.hh View 3 chunks +4 lines, -2 lines 0 comments Download
A lily/include/page-layout-problem.hh View 1 chunk +74 lines, -0 lines 0 comments Download
M lily/include/page-spacing.hh View 1 chunk +3 lines, -3 lines 0 comments Download
A lily/include/staff-grouper-interface.hh View 1 chunk +22 lines, -0 lines 0 comments Download
A lily/include/vertical-align-engraver.hh View 1 chunk +37 lines, -0 lines 0 comments Download
M lily/page-breaking.cc View 19 chunks +126 lines, -53 lines 0 comments Download
A lily/page-layout-problem.cc View 1 chunk +640 lines, -0 lines 0 comments Download
M lily/page-spacing.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A lily/staff-grouper-engraver.cc View 1 chunk +67 lines, -0 lines 1 comment Download
A lily/staff-grouper-interface.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M lily/system-scheme.cc View 1 chunk +0 lines, -43 lines 0 comments Download
M lily/vertical-align-engraver.cc View 4 chunks +23 lines, -28 lines 0 comments Download
M ly/engraver-init.ly View 9 chunks +12 lines, -2 lines 0 comments Download
M ly/paper-defaults-init.ly View 3 chunks +9 lines, -25 lines 0 comments Download
M python/convertrules.py View 1 chunk +19 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 8 chunks +38 lines, -6 lines 0 comments Download
M scm/define-grobs.scm View 5 chunks +11 lines, -7 lines 0 comments Download
M scm/layout-page-dump.scm View 1 chunk +0 lines, -147 lines 0 comments Download
M scm/layout-page-layout.scm View 1 chunk +0 lines, -469 lines 0 comments Download
M scm/page.scm View 2 chunks +2 lines, -4 lines 0 comments Download
M scm/paper.scm View 2 chunks +1 line, -7 lines 0 comments Download
M scm/paper-system.scm View 1 chunk +17 lines, -16 lines 0 comments Download

Messages

Total messages: 1
Patrick McCarty
14 years, 9 months ago (2009-07-27 05:42:20 UTC) #1
I don't really understand the code from this patchset, but I just have one quick
comment.

Thanks,
Patrick

http://codereview.appspot.com/97119/diff/1/22
File lily/staff-grouper-engraver.cc (right):

http://codereview.appspot.com/97119/diff/1/22#newcode21
Line 21: {
Are engravers allowed to inherit code from other classes?

I'm asking because there is a comment in slur-engraver.cc:

   (on principle, engravers don't use inheritance for code sharing)

If the inheritance is okay, then the comment (and others, if any) should be
removed from the slur-engraver.cc.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b