Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(425)

Issue 97059: Fix valgrind warnings triggered in vertical mode.

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 4 months ago by agl
Modified:
15 years, 4 months ago
Reviewers:
reed
Visibility:
Public.

Description

Fix valgrind warnings triggered in vertical mode. Now that Chrome is rendering subpixel text, I was able to try running the renderer process under valgrind, which turned up a number of issues. First, I was calculating the stride of vertical LCD glyphs wrong (typo). Secondly, I was going horribly wrong when a glyph was being blitted at the edge of a bitmap. I suspected something was wrong with the code, but I wasn't clear enough with the structure of the code when writing it to figure out what the correct solution was.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -19 lines) Patch
M src/core/SkBlitter_ARGB32.cpp View 6 chunks +19 lines, -18 lines 0 comments Download
M src/core/SkBlitter_ARGB32_Subpixel.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_FreeType_Subpixel.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
agl
15 years, 4 months ago (2009-07-22 01:40:33 UTC) #1
reed
15 years, 4 months ago (2009-07-22 20:50:16 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b