Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(606)

Issue 970: Adding "close issue" feature (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by jiayao
Modified:
14 years, 8 months ago
Reviewers:
GvR
Base URL:
http://rietveld.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : revert index.yaml #

Patch Set 3 : review updates, and a basic admin page for bulk editing existing entities #

Patch Set 4 : revert index.yaml #

Patch Set 5 : Review changes, reverted admin page because we decided to use the built in admin console #

Patch Set 6 : remove the close button, which was replaced by the checkbox in the edit form #

Patch Set 7 : Remove the close request handler too #

Patch Set 8 : Changed active flag to closed, and some style fixes #

Patch Set 9 : minor change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -9 lines) Patch
codereview/models.py View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
codereview/views.py View 1 2 3 4 5 6 7 8 8 chunks +22 lines, -6 lines 1 comment Download
templates/edit.html View 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
templates/issue.html View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
templates/mine.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 9
jiayao
Hi Guido, This is a prototype of the Close feature. Let me know if this ...
15 years, 10 months ago (2008-05-13 09:45:40 UTC) #1
GvR
Good start! What do you think about changing the UI for seeing closed issues? Most ...
15 years, 10 months ago (2008-05-13 17:05:31 UTC) #2
jiayao
Hi Guido, I've addressed your comments inline and with another patch. And I've added a ...
15 years, 10 months ago (2008-05-13 23:00:48 UTC) #3
GvR
Good start. Some comments inline... http://codereview.appspot.com/970/diff/9/102 File codereview/views.py (right): http://codereview.appspot.com/970/diff/9/102#newcode205 Line 205: max_length=30, Please line ...
15 years, 10 months ago (2008-05-14 00:30:30 UTC) #4
GvR
By the way, I wonder if a better alternative to the batch edit command isn't ...
15 years, 10 months ago (2008-05-14 15:12:27 UTC) #5
jiayao
http://codereview.appspot.com/970/diff/9/102 File codereview/views.py (right): http://codereview.appspot.com/970/diff/9/102#newcode354 Line 354: query = db.GqlQuery('SELECT * FROM Issue WHERE active=True ...
15 years, 10 months ago (2008-05-14 18:43:51 UTC) #6
GvR
I like it! Two requests: 1. some blank lines got lost (see comments) 2. how ...
15 years, 10 months ago (2008-05-14 19:05:33 UTC) #7
jiayao
Good suggestion about changing flag active to closed. I just realised whenever 'active' is used, ...
15 years, 10 months ago (2008-05-14 21:45:52 UTC) #8
GvR
15 years, 10 months ago (2008-05-14 23:24:24 UTC) #9
Great!  Fix the unused import and submit it!  Thanks so much.

http://codereview.appspot.com/970/diff/67/150
File codereview/views.py (right):

http://codereview.appspot.com/970/diff/67/150#newcode38
Line 38: from google.appengine.ext.db import KindError
This is no longer needed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b