Issue 96211: Allow setting compression level on GzipOutputStream

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 96211: Allow setting compression level on GzipOutputStream

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by kenton

Modified:
14 years, 8 months ago

Reviewers:
peter.keen

CC:
protobuf_googlegroups.com

Base URL:
http://protobuf.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Hi Peter, I decided to extend this patch a bit. I didn't like all the default options to the constructor, so I created a separate Options struct -- this way people don't have to set a buffer size in order to set compression level (which is good because almost no one should care about buffer size). I also added tests. At Google we have a policy of reviewing all code before submission, so please take a look at the diffs and let me know if it looks good to you.

Patch Set 1 #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -13 lines)			Patch
M	src/google/protobuf/io/gzip_stream.h	View	2 chunks	+35 lines, -4 lines	0 comments	Download
M	src/google/protobuf/io/gzip_stream.cc	View	2 chunks	+34 lines, -9 lines	0 comments	Download
M	src/google/protobuf/io/zero_copy_stream_unittest.cc	View	3 chunks	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

peter.keen

14 years, 8 months ago (2009-08-01 00:08:45 UTC) #2

On 2009/07/31 23:56:40, kenton wrote:
> 
 This looks great, Kenton. Thanks for cleaning it up! The tests look pretty
decent as well. With such a small golden message you're probably not going to
see any difference between the different compression levels, and it is just
passed through to zlib so there's probably no point in testing it here.

Expand All Messages | Collapse All Messages