Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(172)

Issue 96171: Support subpixel text when FreeType is built without support.

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 3 months ago by agl
Modified:
15 years, 3 months ago
Reviewers:
evan
Visibility:
Public.

Description

Support subpixel text when FreeType is built without support. On Fedora, at least, FreeType is built without subpixel support. It tries to simulate subpixel mode by replicating the gray-values three times. However, it fails to simulate the actions of the low-pass filter and so doesn't add border around the glyphs. This patch adds a compile-time constant, which is the number of bytes of filter border. If this value is zero (because FreeType is simulating subpixel support), then we add a transparent border ourselves when transforming from FreeType rendered glyphs to masks.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -7 lines) Patch
M src/ports/SkFontHost_FreeType_Subpixel.cpp View 9 chunks +28 lines, -7 lines 1 comment Download

Messages

Total messages: 2
agl
15 years, 3 months ago (2009-07-27 23:49:12 UTC) #1
evan
15 years, 3 months ago (2009-07-28 00:00:17 UTC) #2
as a transformation of the source to introduce a constant, it seems correct, but
the reasoning behind this is completely opaque to me.  perhaps you could improve
the review description.

http://codereview.appspot.com/96171/diff/1/2
File src/ports/SkFontHost_FreeType_Subpixel.cpp (right):

http://codereview.appspot.com/96171/diff/1/2#newcode40
Line 40: static const int kFilterBorderWidth = 3;
might be nice to copy the review description into here as a comment.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b