Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2274)

Issue 96165: Fix compliation on gcc-4.3 and ARMv5T (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 1 month ago by Joel
Modified:
15 years ago
Reviewers:
reed, deanm
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix compliation on gcc-4.3 and ARMv5T - smulbb is only on ARMv5TE and above (p316, ARM Architecture Reference Manual) - an empty clobber list causes a compiler error with my compiler, gcc-4.3.2 Patch by Joel Stanley <joel@jms.id.au>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M include/core/SkMath.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Joel
Having not used gcl before, this change automaticly came to the appspot rietveld instead of ...
15 years, 1 month ago (2009-07-27 07:41:36 UTC) #1
deanm
15 years, 1 month ago (2009-08-03 16:17:46 UTC) #2
reed
15 years, 1 month ago (2009-08-03 17:25:24 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b