Issue 958043: Added support for building glsl translator on posix platforms.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 958043: Added support for building glsl translator on posix platforms. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by Alok Priyadarshi

Modified:
14 years, 5 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added support for building glsl translator on posix platforms.

Patch Set 2 : '' #

Total comments: 2

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -69 lines)			Patch
M	src/build_angle.gyp	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	src/compiler/osinclude.h	View		1 chunk	+28 lines, -7 lines	0 comments	Download
D	src/compiler/ossource.cpp	View		1 chunk	+0 lines, -57 lines	0 comments	Download
A	src/compiler/ossource_posix.cpp	View	1	1 chunk	+111 lines, -0 lines	2 comments	Download
A +	src/compiler/ossource_win.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/translator_common.vcproj	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kbr1

LGTM http://codereview.appspot.com/958043/diff/2001/3002 File src/compiler/ossource_posix.cpp (right): http://codereview.appspot.com/958043/diff/2001/3002#newcode74 src/compiler/ossource_posix.cpp:74: assert(0 && "OS_AllocTLSIndex(): Unable to allocate Thread Local ...

14 years, 5 months ago (2010-04-23 00:19:49 UTC) #2

Alok Priyadarshi

14 years, 5 months ago (2010-04-23 16:06:39 UTC) #4

http://codereview.appspot.com/958043/diff/2001/3002
File src/compiler/ossource_posix.cpp (right):

http://codereview.appspot.com/958043/diff/2001/3002#newcode74
src/compiler/ossource_posix.cpp:74: assert(0 && "OS_AllocTLSIndex(): Unable to
allocate Thread Local Storage");
On 2010/04/23 00:19:50, kbr1 wrote:
> >80 chars
> 

Ken: we do not follow google style guide in angle :)

Expand All Messages | Collapse All Messages