Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1263)

Issue 956051: Fix #943. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by Patrick McCarty
Modified:
14 years ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix #943. See: http://code.google.com/p/lilypond/issues/detail?id=943 - Currently, slur direction is calculated once and possibly modified later. Combine these routines into a single function. - Check for a post-line-break slur first; in this case, the direction should come from the pre-line-break slur. - Check for a pre-line-break slur next; if found, forward its direction to the corresponding post-line-break slur. - If these conditions do not hold, we have an unbroken slur, so simply calculate its direction.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M lily/include/slur-scoring.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/slur-scoring.cc View 3 chunks +14 lines, -12 lines 2 comments Download

Messages

Total messages: 2
Neil Puttock
LGTM. http://codereview.appspot.com/956051/diff/1/3 File lily/slur-scoring.cc (right): http://codereview.appspot.com/956051/diff/1/3#newcode86 lily/slur-scoring.cc:86: Slur_score_state::slur_direction (Grob *me) const Do you need to ...
14 years ago (2010-04-29 22:40:10 UTC) #1
Patrick McCarty
14 years ago (2010-04-30 03:22:27 UTC) #2
http://codereview.appspot.com/956051/diff/1/3
File lily/slur-scoring.cc (right):

http://codereview.appspot.com/956051/diff/1/3#newcode86
lily/slur-scoring.cc:86: Slur_score_state::slur_direction (Grob *me) const
On 2010/04/29 22:40:10, Neil Puttock wrote:
> Do you need to pass `me' here?  Isn't it the same as slur_?

Oh yes, thanks for the catch.  I'll amend that and push.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b