Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(651)

Issue 956048: Change \cresc,\dim,\decresc to post-fix operators for (de)cresc spanners (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by Reinhold
Modified:
13 years, 11 months ago
Reviewers:
Neil Puttock
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Change \cresc,\dim,\decresc to post-fix operators for (de)cresc spanners -) Implement cresc and co. using the new properties of the (De)CrescendoEvent -) rename old functions as deprecated and implement a convert-ly rule

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -20 lines) Patch
M input/regression/dynamics-text-spanner-postfix.ly View 1 chunk +4 lines, -11 lines 0 comments Download
M ly/spanners-init.ly View 1 chunk +14 lines, -9 lines 0 comments Download
M python/convertrules.py View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 1
Neil Puttock
13 years, 11 months ago (2010-04-23 22:06:05 UTC) #1
LGTM.

http://codereview.appspot.com/956048/diff/1/4
File python/convertrules.py (right):

http://codereview.appspot.com/956048/diff/1/4#newcode3001
python/convertrules.py:3001: @rule ((2,13,19),
(2, 13, 19)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b