Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 955: Allow upload with no base (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by Raghu
Modified:
3 months, 2 weeks ago
Reviewers:
GvR, ondrej.certik
CC:
SVN Base:
http://rietveld.googlecode.com/svn/trunk/

Description

I am closing this as Ondrej's patch (1026) includes code from this one.

Patch Set 1

Total comments: 3

Patch Set 2 : I incorporated the changes as per your comments in previous patch.

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
codereview/models.py View 1 1 chunk 13 lines 1 comment Download
codereview/views.py View 2 chunks 32 lines 1 comment Download
static/upload.py View 1 3 chunks 37 lines 0 comments Download

Messages

Total messages: 6
GvR
http://codereview.appspot.com/955/diff/1/3 File codereview/models.py (right): http://codereview.appspot.com/955/diff/1/3#newcode65 Line 65: base = db.StringProperty() Why do you need that? ...
6 months, 3 weeks ago
Raghu
6 months, 3 weeks ago
Raghu
I should mention that this code should be treated as only prototype. That is the ...
6 months, 3 weeks ago
GvR
Are you asking for feedback? This code seems to be too incomplete to be able ...
6 months, 2 weeks ago
Raghu
> Are you asking for feedback? This code seems to be too > incomplete to ...
6 months, 2 weeks ago
ondrej.certik
6 months, 2 weeks ago
> Sorry. I merely intended this as a starting point for Ondrej > or who ever
else
> wanting to implement Plan B (as described on 
> codereview-discuss list). 

Thanks for your work! I based my upload base files patch on yours here:

http://codereview.appspot.com/1026
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld r373