Allow upload with no base

I am closing this as Ondrej's patch (1026) includes code from this one.

[GvR, 2008-05-17 03:29:01]

http://codereview.appspot.com/955/diff/1/3
File codereview/models.py (right):

http://codereview.appspot.com/955/diff/1/3#newcode65
Line 65: base = db.StringProperty()
Why do you need that?  You could just set it to the None value (not the string
"None") since that's a valid value for any property that doesn't have
Required=True (except list properies).

http://codereview.appspot.com/955/diff/1/2
File static/upload.py (right):

http://codereview.appspot.com/955/diff/1/2#newcode364
Line 364: parser.add_option("--lb", action="store_true",
I recommend "-l", "--local_base"

http://codereview.appspot.com/955/diff/1/2#newcode502
Line 502: base = "None"
I'd set it to the empty string. That should be turned into an absent value on
the server end.

[Raghu, 2008-05-17 06:04:20]

I should mention that this code should be treated as only prototype. That is the
reason I am blandly returning an info message directly from view.py (instead of
having a template etc).

[GvR, 2008-05-19 02:10:58]

Are you asking for feedback? This code seems to be too incomplete to be able to
comment much.

http://codereview.appspot.com/955/diff/81/7
File codereview/models.py (right):

http://codereview.appspot.com/955/diff/81/7#newcode65
Line 65: base = None
Have you actually tested this code?  I meant leaving it to be a URLProperty
rather than making it a StringProperty (assuming you made it a StringProperty to
be able to assign None to it).

http://codereview.appspot.com/955/diff/81/6
File codereview/views.py (left):

http://codereview.appspot.com/955/diff/81/6#oldcode157
Line 157: 
Please don't delete double blank lines.  They're there for a reason.

[Raghu, 2008-05-19 11:31:42]

> Are you asking for feedback? This code seems to be too 
> incomplete to be able to comment much.

Sorry. I merely intended this as a starting point for Ondrej or who ever else
wanting to implement Plan B (as described on codereview-discuss list). I did
test it with "-l" option but not with regular case and now realize that setting
"base" to "None" in Issue is wrong. 

I will try to do a more thorough job in future.

[ondrej.certik, 2008-05-19 12:22:23]

> Sorry. I merely intended this as a starting point for Ondrej > or who ever
else
> wanting to implement Plan B (as described on 
> codereview-discuss list). 

Thanks for your work! I based my upload base files patch on yours here:

http://codereview.appspot.com/1026