static/upload.py - Issue 955: Allow upload with no base

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
j / k :	jump to file after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue


	Comment editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: static/upload.py

Issue 955: Allow upload with no base (Closed) SVN Base: http://rietveld.googlecode.com/svn/trunk/

Patch Set: Created 3 months, 3 weeks ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: static/upload.py

===================================================================

--- static/upload.py (revision 103)

+++ static/upload.py (working copy)

@@ -361,6 +361,9 @@

parser.add_option("-i", "--issue", type="int", action="store",

metavar="ISSUE", default=None,

help="Issue number to which to add. Defaults to new issue.")

+parser.add_option("--lb", action="store_true",

GvR 2008/05/17 03:29:02 I recommend "-l", "--local_base"

+ dest="local_base", default=False,

+ help="base file will be uploaded")

def GetRpcServer(options):

@@ -495,7 +498,10 @@

logging.getLogger().setLevel(logging.DEBUG)

elif verbosity >= 2:

logging.getLogger().setLevel(logging.INFO)

- base = GuessBase()

+ if options.local_base:

+ base = "None"

GvR 2008/05/17 03:29:02 I'd set it to the empty string. That should be tur

+ else:

+ base = GuessBase()

CheckForUnknownFiles()

data = RunShell("svn diff", args)

count = 0

« codereview/models.py ('k') | no next file »