Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(820)

Issue 953: astype sometimes fails to return a copy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 10 months ago by ondrej.certik
Modified:
14 years, 7 months ago
Reviewers:
stefanv, efiring
Base URL:
http://svn.scipy.org/svn/numpy/trunk/
Visibility:
Public.

Description

More info here: http://projects.scipy.org/scipy/numpy/ticket/788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
numpy/core/tests/test_regression.py View 2 chunks +12 lines, -1 line 7 comments Download

Messages

Total messages: 9
ondrej.certik
My comments. http://codereview.appspot.com/953/diff/1/2 File numpy/core/tests/test_regression.py (right): http://codereview.appspot.com/953/diff/1/2#newcode5 Line 5: import os as _os Why are ...
15 years, 10 months ago (2008-05-14 21:03:12 UTC) #1
stefanv
Test codereview. Some insightful message. http://codereview.appspot.com/953/diff/1/2 File numpy/core/tests/test_regression.py (right): http://codereview.appspot.com/953/diff/1/2#newcode1029 Line 1029: """Ticket 788, changeset ...
15 years, 10 months ago (2008-05-14 21:39:22 UTC) #2
ondrej.certik
My reply. http://codereview.appspot.com/953/diff/1/2 File numpy/core/tests/test_regression.py (right): http://codereview.appspot.com/953/diff/1/2#newcode1029 Line 1029: """Ticket 788, changeset r5155""" On 2008/05/14 ...
15 years, 10 months ago (2008-05-14 21:41:02 UTC) #3
stefanv
http://codereview.appspot.com/953/diff/1/2 File numpy/core/tests/test_regression.py (right): http://codereview.appspot.com/953/diff/1/2#newcode1033 Line 1033: filename = _os.path.join(__path__[0], "testdata_astype.pkl") On 2008/05/14 21:03:12, ondrej.certik ...
15 years, 10 months ago (2008-05-14 22:19:26 UTC) #4
ondrej.certik
I suggest to get a feedback on the issues above and fix the mentioned problems ...
15 years, 10 months ago (2008-05-14 22:24:37 UTC) #5
stefanv
This test is urgently needed to address a previously closed ticket, so I suggest we ...
15 years, 10 months ago (2008-05-14 23:36:42 UTC) #6
efiring
http://codereview.appspot.com/953/diff/1/2 File numpy/core/tests/test_regression.py (right): http://codereview.appspot.com/953/diff/1/2#newcode5 Line 5: import os as _os On 2008/05/14 21:03:12, ondrej.certik ...
15 years, 10 months ago (2008-05-14 23:37:05 UTC) #7
stefanv
Applied to trunk. Please close.
15 years, 10 months ago (2008-05-21 09:29:20 UTC) #8
ondrej.certik
15 years, 10 months ago (2008-05-21 09:31:47 UTC) #9
Thanks for pushing this in. Closed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b