Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(3977)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
95250047
: SLING-3499 - refactoring
Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by
justinedelson
Modified:
9 years, 7 months ago
Reviewers:
Visibility:
Public.
More Reviews
Description
SLING-3499 - refactoring
Patch Set 1
#
Created:
9 years, 11 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+1138 lines, -284 lines
)
Patch
A
bundles/extensions/models/api/src/main/java/org/apache/sling/models/annotations/injectorspecific/ChildResource.java
View
1 chunk
+56 lines, -0 lines
0 comments
Download
A
bundles/extensions/models/api/src/main/java/org/apache/sling/models/annotations/injectorspecific/OSGiService.java
View
1 chunk
+51 lines, -0 lines
0 comments
Download
A
bundles/extensions/models/api/src/main/java/org/apache/sling/models/annotations/injectorspecific/RequestAttribute.java
View
1 chunk
+52 lines, -0 lines
0 comments
Download
A
bundles/extensions/models/api/src/main/java/org/apache/sling/models/annotations/injectorspecific/ScriptVariable.java
View
1 chunk
+51 lines, -0 lines
0 comments
Download
A
bundles/extensions/models/api/src/main/java/org/apache/sling/models/annotations/injectorspecific/ValueMapValue.java
View
1 chunk
+56 lines, -0 lines
0 comments
Download
A +
bundles/extensions/models/api/src/main/java/org/apache/sling/models/annotations/injectorspecific/package-info.java
View
1 chunk
+1 line, -1 line
0 comments
Download
A +
bundles/extensions/models/api/src/main/java/org/apache/sling/models/spi/injectorspecific/AbstractInjectAnnotationProcessor.java
View
1 chunk
+22 lines, -12 lines
0 comments
Download
A +
bundles/extensions/models/api/src/main/java/org/apache/sling/models/spi/injectorspecific/InjectAnnotation.java
View
1 chunk
+10 lines, -10 lines
0 comments
Download
A
bundles/extensions/models/api/src/main/java/org/apache/sling/models/spi/injectorspecific/InjectAnnotationProcessor.java
View
1 chunk
+59 lines, -0 lines
0 comments
Download
A +
bundles/extensions/models/api/src/main/java/org/apache/sling/models/spi/injectorspecific/InjectAnnotationProcessorFactory.java
View
1 chunk
+10 lines, -8 lines
0 comments
Download
A +
bundles/extensions/models/api/src/main/java/org/apache/sling/models/spi/injectorspecific/package-info.java
View
1 chunk
+1 line, -1 line
0 comments
Download
M
bundles/extensions/models/impl/pom.xml
View
1 chunk
+1 line, -1 line
0 comments
Download
M
bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/ModelAdapterFactory.java
View
12 chunks
+217 lines, -186 lines
0 comments
Download
M
bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/BindingsInjector.java
View
4 chunks
+41 lines, -2 lines
0 comments
Download
M
bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/ChildResourceInjector.java
View
3 chunks
+58 lines, -2 lines
0 comments
Download
M
bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/OSGiServiceInjector.java
View
8 chunks
+52 lines, -12 lines
0 comments
Download
M
bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/RequestAttributeInjector.java
View
3 chunks
+44 lines, -4 lines
0 comments
Download
M
bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/injectors/ValueMapInjector.java
View
3 chunks
+59 lines, -3 lines
0 comments
Download
A
bundles/extensions/models/impl/src/test/java/org/apache/sling/models/impl/InjectorSpecificAnnotationTest.java
View
1 chunk
+184 lines, -0 lines
0 comments
Download
M
bundles/extensions/models/impl/src/test/java/org/apache/sling/models/impl/MultipleInjectorTest.java
View
1 chunk
+1 line, -0 lines
0 comments
Download
A
bundles/extensions/models/impl/src/test/java/org/apache/sling/models/testmodels/classes/InjectorSpecificAnnotationModel.java
View
1 chunk
+82 lines, -0 lines
0 comments
Download
A +
bundles/extensions/models/integration-tests/src/main/java/org/apache/sling/models/it/InjectorSpecificAnnotationTest.java
View
3 chunks
+26 lines, -27 lines
0 comments
Download
A +
bundles/extensions/models/integration-tests/src/main/java/org/apache/sling/models/it/models/SlingPropertyAnnotationTestModel.java
View
1 chunk
+4 lines, -15 lines
0 comments
Download
Issue 95250047: SLING-3499 - refactoring
Created 9 years, 11 months ago by justinedelson
Modified 9 years, 7 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b