Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 950041: Add a SkTypeface::CreateForChars() function....

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by evan
Modified:
14 years, 2 months ago
Reviewers:
agl, Stephen White
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add a SkTypeface::CreateForChars() function. This allows us to do font fallback for strange scripts. Added empty stubs to the implementations on all platforms.

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -15 lines) Patch
M include/core/SkFontHost.h View 1 1 chunk +8 lines, -6 lines 0 comments Download
M include/core/SkTypeface.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M src/ports/SkFontHost_FONTPATH.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_android.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/ports/SkFontHost_none.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/ports/SkFontHost_simple.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
evan
Not sure who should review this. I have a Chrome-side change that needs this API ...
14 years, 2 months ago (2010-04-20 21:28:01 UTC) #1
agl
LGTM http://codereview.appspot.com/950041/diff/1/3 File include/core/SkFontHost.h (right): http://codereview.appspot.com/950041/diff/1/3#newcode62 include/core/SkFontHost.h:62: (specified by a typeface in that family) or ...
14 years, 2 months ago (2010-04-20 21:34:54 UTC) #2
evan
New version up. Can you land it for me?
14 years, 2 months ago (2010-04-20 21:55:42 UTC) #3
agl
14 years, 2 months ago (2010-04-20 22:07:22 UTC) #4
On Tue, Apr 20, 2010 at 5:55 PM,  <evan@chromium.org> wrote:
> New version up.  Can you land it for me?

r557


AGL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b