Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25)

Issue 950: Google App Engine Django - Deserialize db.DateTimeProperty

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by mattbrown.nz
Modified:
3 months, 2 weeks ago
Reviewers:
GvR
CC:
SVN Base:
http://google-app-engine-django.googlecode.com/svn/trunk/

Patch Set 1

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
appengine_django/serializer/python.py View 4 chunks 53 lines 5 comments Download
appengine_django/serializer/xml.py View 3 chunks 47 lines 2 comments Download

Messages

Total messages: 2
GvR
Here are some comments. http://codereview.appspot.com/950/diff/1/3 File appengine_django/serializer/python.py (right): http://codereview.appspot.com/950/diff/1/3#newcode80 Line 80: TIME_FORMAT = "%H:%M:%S" I ...
6 months, 3 weeks ago
GvR
6 months, 3 weeks ago
Minor separate comments on this code.

http://codereview.appspot.com/950/diff/1/3
File appengine_django/serializer/python.py (right):

http://codereview.appspot.com/950/diff/1/3#newcode122
Line 122: if isinstance(field, db.Reference):
PS. Should use db.ReferenceProperty here -- db.Reference is deprecated.

http://codereview.appspot.com/950/diff/1/2
File appengine_django/serializer/xml.py (right):

http://codereview.appspot.com/950/diff/1/2#newcode129
Line 129: if isinstance(field, db.Reference):
PS. Should use db.ReferenceProperty here -- db.Reference is deprecated.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld r373