Issue 9466: Beginnings of module build task for non-Cajoled JS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9466: Beginnings of module build task for non-Cajoled JS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 4 months ago by ihab.awad

Modified:
16 years, 8 months ago

Reviewers:
MikeSamuel

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Closing this issue -- we will revisit this design later.

Patch Set 1 #

Created: 17 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1147 lines, -1921 lines)			Patch
M	experimental/prototype/Rakefile	View	1 chunk	+2 lines, -1 line	1 comment	Download
M	experimental/prototype/build.sh	View	1 chunk	+2 lines, -2 lines	0 comments	Download
A	src/com/google/caja/domita/ModuleNameTracker.java	View	1 chunk	+77 lines, -0 lines	5 comments	Download
A	src/com/google/caja/domita/ModuleRewriter.java	View	1 chunk	+28 lines, -0 lines	1 comment	Download
A	src/com/google/caja/domita/ProgramRewriter.java	View	1 chunk	+27 lines, -0 lines	1 comment	Download
A	src/com/google/caja/domita/ScriptCompiler.java	View	1 chunk	+83 lines, -0 lines	2 comments	Download
A	src/com/google/caja/domita/ScriptCompilerCommand.java	View	1 chunk	+56 lines, -0 lines	3 comments	Download
A	src/com/google/caja/domita/ScriptContext.java	View	1 chunk	+40 lines, -0 lines	0 comments	Download
A	src/com/google/caja/domita/ScriptRewriter.java	View	1 chunk	+71 lines, -0 lines	1 comment	Download
M	src/com/google/caja/parser/quasiliteral/CajitaRewriter.java	View	161 chunks	+201 lines, -200 lines	0 comments	Download
A	src/com/google/caja/parser/quasiliteral/CatchStmtScope.java	View	1 chunk	+37 lines, -0 lines	2 comments	Download
M	src/com/google/caja/parser/quasiliteral/DefaultValijaRewriter.java	View	94 chunks	+163 lines, -162 lines	1 comment	Download
A	src/com/google/caja/parser/quasiliteral/FunctionConstructorScope.java	View	1 chunk	+53 lines, -0 lines	3 comments	Download
M	src/com/google/caja/parser/quasiliteral/IllegalReferenceCheckRewriter.java	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/com/google/caja/parser/quasiliteral/InnocentCodeRewriter.java	View	8 chunks	+13 lines, -14 lines	0 comments	Download
A +	src/com/google/caja/parser/quasiliteral/JsRule.java	View	11 chunks	+16 lines, -164 lines	0 comments	Download
A +	src/com/google/caja/parser/quasiliteral/JsScope.java	View	14 chunks	+24 lines, -125 lines	0 comments	Download
A	src/com/google/caja/parser/quasiliteral/ParseTreeNodeContainerScope.java	View	1 chunk	+33 lines, -0 lines	1 comment	Download
A	src/com/google/caja/parser/quasiliteral/PlainBlockScope.java	View	1 chunk	+33 lines, -0 lines	2 comments	Download
A	src/com/google/caja/parser/quasiliteral/ProgramScope.java	View	1 chunk	+38 lines, -0 lines	1 comment	Download
M	src/com/google/caja/parser/quasiliteral/Rewriter.java	View	7 chunks	+24 lines, -18 lines	1 comment	Download
R	src/com/google/caja/parser/quasiliteral/Rule.java	View	8 chunks	+17 lines, -423 lines	1 comment	Download
M	src/com/google/caja/parser/quasiliteral/RuleChain.java	View	4 chunks	+16 lines, -10 lines	2 comments	Download
M	src/com/google/caja/parser/quasiliteral/RuleDoclet.java	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	src/com/google/caja/parser/quasiliteral/Scope.java	View	1 chunk	+0 lines, -709 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/CajaRuntimeDebuggingRewriter.java	View	20 chunks	+25 lines, -25 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/InferFilePositionsStage.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/parser/quasiliteral/RewriterTest.java	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/com/google/caja/parser/quasiliteral/RewriterTestCase.java	View	6 chunks	+13 lines, -13 lines	0 comments	Download
M	tests/com/google/caja/parser/quasiliteral/ScopeTest.java	View	20 chunks	+38 lines, -38 lines	0 comments	Download
M	tests/com/google/caja/plugin/ExpressionSanitizerTest.java	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

MikeSamuel

17 years, 4 months ago (2008-11-25 06:18:09 UTC) #1

There doesn't seem to be enough on the module stuff to really comment.

The Scope and Rule reorganization looks alright with nits inline, but I don't
understand what it has to do with the module stuff.

Expand All Messages | Collapse All Messages