Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 9465: py2exe fixes for 1.1.8 release (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 2 months ago by Tom
Modified:
16 years, 6 months ago
Reviewers:
Joe Hughes
CC:
googletransitdatafeed_googlegroups.com
Visibility:
Public.

Description

put the py2exe output in the directory 'transitfeed-windows-binary-%s' % VERSION so I don't need to type the name when creating the zip fix for issue 121: zoneinfo not included in py2exe library.zip http://code.google.com/p/googletransitdatafeed/issues/detail?id=121

Patch Set 1 #

Patch Set 2 : merged changes from trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M python/setup.py View 2 chunks +18 lines, -0 lines 2 comments Download

Messages

Total messages: 3
Tom
I started making the 1.1.8 release and ran into trouble with py2exe and pytz. Once ...
17 years, 2 months ago (2008-11-24 23:19:16 UTC) #1
Joe Hughes
Looks good, glad you were able to find a workaround. http://codereview.appspot.com/9465/diff/204/5 File python/setup.py (right): http://codereview.appspot.com/9465/diff/204/5#newcode93 ...
17 years, 2 months ago (2008-11-25 08:12:19 UTC) #2
Tom
17 years, 2 months ago (2008-11-25 19:23:35 UTC) #3
Thanks for reviewing this.

I fixed what you found, loosened an assert that failed on a new machine,
commited http://code.google.com/p/googletransitdatafeed/source/detail?r=932, and
made a new tags/transitfeed-1.1.8

I also updated
http://code.google.com/p/googletransitdatafeed/wiki/BuildingPythonWindowsExec...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b