Generate a .pe script for one design size at a time.

Generate a .pe script for one design size at a time.
    
In make
    
     a b: c
       command
    
is shorthand for
    
     a: c
       command
     b: c
       command
    
this means that in parallel builds the same command may be invoked twice.
    
Fix this by associating each command with only one target, and adding dummy dependencies. Also, generate the .pe for only one design size at a time.

[hanwenn, 2014-05-15 09:22:49]

disambiguate generate pe files

[hanwenn, 2014-05-17 14:13:29]

remove more cruft

[hanwenn, 2014-05-17 14:16:28]

please review.

[lemzwerg, 2014-05-17 15:13:20]

https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile
File mf/GNUmakefile (right):

https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile#newcode119
mf/GNUmakefile:119: true
Does this really work?  I've never seen a make rule like that, and my gut
feeling says that it could be still suffering from race conditions.  Hopefully,
I'm wrong.

The automake info file has a long section w.r.t. commands that produce multiple
output files.  Interestingly, your solution with `true' isn't documented
there...

https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile#newcode136
mf/GNUmakefile:136: # generating 3 files at the same time
This comment should be moved up to the first use of `true'.

[hanwenn, 2014-05-18 12:24:09]

touch targets

[hanwenn, 2014-05-18 12:33:50]

comment

[hanwenn, 2014-05-18 12:33:58]

On 2014/05/17 15:13:20, lemzwerg wrote:
> https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile
> File mf/GNUmakefile (right):
> 
> https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile#newcode119
> mf/GNUmakefile:119: true
> Does this really work?  I've never seen a make rule like that, and my gut
> feeling says that it could be still suffering from race conditions. 
Hopefully,
> I'm wrong.

yes, it works.  The previous version still has a problem if the script creates
the SVG before the OTF, so I've added a touch to the dummy rules, so the
timestamps reflect the declared dependencies. 

The only situation where this goes wrong is when the .SVG file does not exist,
but the .OTF does, since the recipe doesn't actually produce the .SVG. Since
this is unlikely to occur in practice, I suggest to ignore this situation.

> The automake info file has a long section w.r.t. commands that produce
multiple
> output files.  Interestingly, your solution with `true' isn't documented
> there...

this is a variation of the 2nd approach in 

http://www.gnu.org/software/automake/manual/html_node/Multiple-Outputs.html

they try to fix it by introducing complex shell which can go wrong in even more
ways.

The really correct is to treat the multiple outputs as one intermediate file,
ie. have the rule creating multiple outputs create a .zip file, and unpack the
final output from the .zip.

> https://codereview.appspot.com/93430043/diff/40001/mf/GNUmakefile#newcode136
> mf/GNUmakefile:136: # generating 3 files at the same time
> This comment should be moved up to the first use of `true'.

done.

[lemzwerg, 2014-05-18 16:38:29]

LGTM now, thanks.

[hanwenn, 2014-05-20 19:38:58]

what's the procedure for pushing this after the LGTM? Can I just push
the commit onto master?

On Sun, May 18, 2014 at 6:38 PM,  <lemzwerg@googlemail.com> wrote:
> LGTM now, thanks.
>
> https://codereview.appspot.com/93430043/



-- 
Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

[dak, 2014-05-20 19:58:40]

Han-Wen Nienhuys <hanwenn@gmail.com> writes:

> what's the procedure for pushing this after the LGTM? Can I just push
> the commit onto master?
>
> On Sun, May 18, 2014 at 6:38 PM,  <lemzwerg@googlemail.com> wrote:
>> LGTM now, thanks.
>>
>> https://codereview.appspot.com/93430043/

LGTM is just a thumbs-up from one reviewer.  If the review looks
favorably, the patch will be promoted to Patch-push status by the Patch
meister eventually.  That's when one can rebase and push the patch to
staging (never! master) and mark the issue as fixed.  Automated
procedures will do a complete check of staging regularly (every few
hours) and push it to master when it passes all of a number of checks.

-- 
David Kastrup