i did not see any tests. http://codereview.appspot.com/933/diff/1/3 File display/handler_stats.py (right): http://codereview.appspot.com/933/diff/1/3#newcode8 Line 8: import cgi this is no alpha ordered. http://codereview.appspot.com/933/diff/1/3#newcode11 Line 11: import model there is a comment missing here about what model provides for your code. http://codereview.appspot.com/933/diff/1/3#newcode32 Line 32: def post(self): how about you provide comments for your methods? heh? how is anyone supposed to understand your cryptic code otherwise? http://codereview.appspot.com/933/diff/1/3#newcode34 Line 34: if model.models.Digest.gql("WHERE hash = :1", hash).get() is None: this looks like SQL, but SQL does not have a = space colon comperator. http://codereview.appspot.com/933/diff/1/3#newcode38 Line 38: logging.info("Added digest %s" % hash) i have seen this kind of code somewhere else before. http://codereview.appspot.com/933/diff/1/4 File display/html/stats.html (right): http://codereview.appspot.com/933/diff/1/4#newcode35 Line 35: <td><input name=digest value="" size=32></td> you should stick with a common standard of representing key value pairs in html tags. either with quotes or without.
fixed and submitting dammit http://codereview.appspot.com/933/diff/1/3 File display/handler_stats.py (right): http://codereview.appspot.com/933/diff/1/3#newcode8 Line 8: import cgi On 2008/05/16 17:24:51, provos wrote: > this is no alpha ordered. Done. http://codereview.appspot.com/933/diff/1/3#newcode32 Line 32: def post(self): On 2008/05/16 17:24:51, provos wrote: > how about you provide comments for your methods? heh? how is anyone supposed to > understand your cryptic code otherwise? Done. http://codereview.appspot.com/933/diff/1/4 File display/html/stats.html (right): http://codereview.appspot.com/933/diff/1/4#newcode35 Line 35: <td><input name=digest value="" size=32></td> On 2008/05/16 17:24:51, provos wrote: > you should stick with a common standard of representing key value pairs in html > tags. either with quotes or without. Done.
