Issue 933: Add Link to Safe Browsing Diagnostic for matching URLs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 933: Add Link to Safe Browsing Diagnostic for matching URLs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
18 years ago by Panayiotis

Modified:
16 years, 6 months ago

Reviewers:
noe, provos

Base URL:
http://malfind2.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 18 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+24 lines, -2 lines)			Patch
display/handler_stats.py	View	2 chunks	+14 lines, -0 lines	7 comments	Download
display/html/results.html	View	2 chunks	+2 lines, -2 lines	0 comments	Download
display/html/stats.html	View	1 chunk	+8 lines, -0 lines	2 comments	Download
index.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
model/__init__.pyc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

provos

i did not see any tests. http://codereview.appspot.com/933/diff/1/3 File display/handler_stats.py (right): http://codereview.appspot.com/933/diff/1/3#newcode8 Line 8: import cgi ...

18 years ago (2008-05-16 17:24:51 UTC) #2

Panayiotis

18 years ago (2008-05-16 17:33:56 UTC) #3

fixed and submitting dammit

http://codereview.appspot.com/933/diff/1/3
File display/handler_stats.py (right):

http://codereview.appspot.com/933/diff/1/3#newcode8
Line 8: import cgi
On 2008/05/16 17:24:51, provos wrote:
> this is no alpha ordered.

Done.

http://codereview.appspot.com/933/diff/1/3#newcode32
Line 32: def post(self):
On 2008/05/16 17:24:51, provos wrote:
> how about you provide comments for your methods? heh?  how is anyone supposed
to
> understand your cryptic code otherwise?

Done.

http://codereview.appspot.com/933/diff/1/4
File display/html/stats.html (right):

http://codereview.appspot.com/933/diff/1/4#newcode35
Line 35: <td><input name=digest value="" size=32></td>
On 2008/05/16 17:24:51, provos wrote:
> you should stick with a common standard of representing key value pairs in
html
> tags.  either with quotes or without.

Done.

Expand All Messages | Collapse All Messages