Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(200)

Issue 933: Add Link to Safe Browsing Diagnostic for matching URLs

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Panayiotis
Modified:
2 months, 1 week ago
Reviewers:
provos, noe
SVN Base:
http://malfind2.googlecode.com/svn/trunk/

Patch Set 1

Total comments: 9
Raw unified diffs Stats Side-by-side diffs with inline comments Delta from patch set
display/handler_stats.py 2 chunks 31 lines 7 comments
display/html/results.html 2 chunks 22 lines 0 comments
display/html/stats.html 1 chunk 19 lines 2 comments
index.yaml 1 chunk 13 lines 0 comments
model/__init__.pyc 0 chunks 4 lines 0 comments

Messages

Total messages: 3
Panayiotis
2 months, 1 week ago
provos
i did not see any tests. http://codereview.appspot.com/933/diff/1/3 File display/handler_stats.py (right): http://codereview.appspot.com/933/diff/1/3#newcode8 Line 8: import cgi ...
2 months, 1 week ago
Panayiotis
2 months, 1 week ago
fixed and submitting dammit

http://codereview.appspot.com/933/diff/1/3
File display/handler_stats.py (right):

http://codereview.appspot.com/933/diff/1/3#newcode8
Line 8: import cgi
On 2008/05/16 17:24:51, provos wrote:
> this is no alpha ordered.

Done.

http://codereview.appspot.com/933/diff/1/3#newcode32
Line 32: def post(self):
On 2008/05/16 17:24:51, provos wrote:
> how about you provide comments for your methods? heh?  how is anyone supposed
to
> understand your cryptic code otherwise?

Done.

http://codereview.appspot.com/933/diff/1/4
File display/html/stats.html (right):

http://codereview.appspot.com/933/diff/1/4#newcode35
Line 35: <td><input name=digest value="" size=32></td>
On 2008/05/16 17:24:51, provos wrote:
> you should stick with a common standard of representing key value pairs in
html
> tags.  either with quotes or without.

Done.
Sign in to reply to this message.

Powered by Google App Engine
This is Rietveld r168