Issue 9243045: Create and use uniquify function for removing duplicate Grobs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9243045: Create and use uniquify function for removing duplicate Grobs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by dak

Modified:
10 years, 9 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Create and use uniquify function for removing duplicate Grobs As opposed to the previous code, this retains the original order, making results independent from GUILE's memory allocation algorithms.

Patch Set 1 #

Patch Set 2 : Let uniquify work in-place, avoiding extra copies #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -7 lines)			Patch
M	lily/accidental-placement.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	lily/grob.cc	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
M	lily/grob-array.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	lily/include/grob.hh	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lily/system.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Let uniquify work in-place, avoiding extra copies

Expand All Messages | Collapse All Messages