third_party/sqlite_google/src/sqlite.h.in - Issue 924: sqlite3 pragma get/set user_version implemented

Delta Between Two Patch Sets: third_party/sqlite_google/src/sqlite.h.in

Issue 924: sqlite3 pragma get/set user_version implemented (Closed) SVN Base: http://google-gears.googlecode.com/svn/contrib/dimitri.glazkov/database2/gears/

Left Patch Set: moved code to btree.c, restructured Created 4 months, 2 weeks ago

Right Patch Set: Created 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 ** 2001 September 15	2 ** 2001 September 15

3 **	3 **

4 ** The author disclaims copyright to this source code. In place of	4 ** The author disclaims copyright to this source code. In place of

5 ** a legal notice, here is a blessing:	5 ** a legal notice, here is a blessing:

6 **	6 **

7 ** May you do good and not evil.	7 ** May you do good and not evil.

8 ** May you find forgiveness for yourself and forgive others.	8 ** May you find forgiveness for yourself and forgive others.

9 ** May you share freely, never taking more than you give.	9 ** May you share freely, never taking more than you give.

10 **	10 **

(...skipping 2647 matching lines...) Show 10 above Show 10 below
2658 ** not possible to increase the size of a blob using this API. If	2658 ** not possible to increase the size of a blob using this API. If

2659 ** offset iOffset is less than n bytes from the end of the blob,	2659 ** offset iOffset is less than n bytes from the end of the blob,

2660 ** [SQLITE_ERROR] is returned and no data is written.	2660 ** [SQLITE_ERROR] is returned and no data is written.

2661 **	2661 **

2662 ** On success, SQLITE_OK is returned. Otherwise, an	2662 ** On success, SQLITE_OK is returned. Otherwise, an

2663 ** [SQLITE_ERROR \| SQLite error code] or an	2663 ** [SQLITE_ERROR \| SQLite error code] or an

2664 ** [SQLITE_IOERR_READ \| extended error code] is returned.	2664 ** [SQLITE_IOERR_READ \| extended error code] is returned.

2665 */	2665 */

2666 int sqlite3_blob_write(sqlite3_blob , const void z, int n, int iOffset);	2666 int sqlite3_blob_write(sqlite3_blob , const void z, int n, int iOffset);

2667	2667

2668 /*	2668 #if !defined(SQLITE_OMIT_PRAGMA) && !defined(SQLITE_OMIT_PARSER)
	Scott.Hess 2008/05/20 18:37:04 Shouldn't this be #if defined(SQLITE_OMIT_PRAGMA)? Shouldn't this be #if defined(SQLITE_OMIT_PRAGMA)? From 10,000 feet, is there any reason we shouldn't just include this without the #ifdef? For our code, we're just going to use this every time (even if we re-enable PRAGMA, I doubt we'll want to bother setting up a PRAGMA statement and executing it). Also, this code should be more clearly marked Gears-specific I'd probably drop the CAPI3REF:, too, because it's part of a documentation system which we aren't going to play nice with. Dimitri 2008/05/21 13:14:31 On 2008/05/20 18:37:04, Scott.Hess wrote: > Should On 2008/05/20 18:37:04, Scott.Hess wrote: > Shouldn't this be #if defined(SQLITE_OMIT_PRAGMA)? > > From 10,000 feet, is there any reason we shouldn't just include this without the > #ifdef? For our code, we're just going to use this every time (even if we > re-enable PRAGMA, I doubt we'll want to bother setting up a PRAGMA statement and > executing it). I agree. Removed #ifdefs. > Also, this code should be more clearly marked Gears-specific I'd probably drop > the CAPI3REF:, too, because it's part of a documentation system which we aren't > going to play nice with. Replaced CAPI3REF: with "Gears-specific:" I think the phrasing makes pretty good sense in this context, let me know if it doesn't work.
2669 ** Gears-specific: Read User Version Value	2669

	2670 /*

	2671 ** CAPI3REF: Read User Version Value

2670 **	2672 **

2671 ** This function reads the user version cookie and sets the value of	2673 ** This function reads the user version cookie and sets the value of

2672 ** user_version to it.	2674 ** user_version to it.

2673 **	2675 **

2674 ** Returns SQLITE_OK on success. Otherwise, an error code is returned	2676 ** Returns SQLITE_OK on success. Otherwise, an error code is returned

2675 */	2677 */

2676 int sqlite3_get_user_version(sqlite3, int user_version);	2678 int sqlite3_pragma_get_user_version(sqlite3, int user_version);

2677	2679

2678 /*	2680 /*

2679 ** Gears-specific: Write User Version Value	2681 ** CAPI3REF: Write User Version Value

2680 **	2682 **

2681 ** This function writes the user version cookie.	2683 ** This function writes the user version cookie.

2682 **	2684 **

2683 ** returns SQLITE_OK on success. Otherwise, an error code is returned	2685 ** returns SQLITE_OK on success. Otherwise, an error code is returned

2684 */	2686 */

2685 int sqlite3_set_user_version(sqlite3*, int user_version);	2687 int sqlite3_pragma_set_user_version(sqlite3*, int user_version);

	2688

	2689 #endif /* SQLITE_OMIT_PRAGMA \|\| SQLITE_OMIT_PARSER */

2686	2690

2687 /*	2691 /*

2688 ** Undo the hack that converts floating point types to integer for	2692 ** Undo the hack that converts floating point types to integer for

2689 ** builds on processors without floating point support.	2693 ** builds on processors without floating point support.

2690 */	2694 */

2691 #ifdef SQLITE_OMIT_FLOATING_POINT	2695 #ifdef SQLITE_OMIT_FLOATING_POINT

2692 # undef double	2696 # undef double

2693 #endif	2697 #endif

2694	2698

2695 #ifdef __cplusplus	2699 #ifdef __cplusplus

2696 } /* End of the 'extern "C"' block */	2700 } /* End of the 'extern "C"' block */

2697 #endif	2701 #endif

2698 #endif	2702 #endif
	Dimitri 2008/05/21 13:14:31 As an aside, what would be a good place for unit t As an aside, what would be a good place for unit tests for this? Should I just put them in gears/database2/ dir?
LEFT	RIGHT