FSA Set filesystemadaptor.src default to empty string rather than null.

This allows init() to throw InvalidConfigurationException if the
    property was not set.

[pjo, 2014-05-14 23:55:34]

LGTM.  Thank you.


- technology's compounding interest
-


On Wed, May 14, 2014 at 4:32 PM, <Brett.Michael.Johnson@gmail.com> wrote:

> Reviewers: pjo, mifern,
>
> Description:
> This allows init() to throw InvalidConfigurationException if the
>     property was not set.
>
> Please review this at http://codereview.appspot.com/91460043/
>
> Affected files (+1, -1 lines):
>   M src/com/google/enterprise/adaptor/fs/FsAdaptor.java
>
>
> Index: src/com/google/enterprise/adaptor/fs/FsAdaptor.java
> diff --git a/src/com/google/enterprise/adaptor/fs/FsAdaptor.java
> b/src/com/google/enterprise/adaptor/fs/FsAdaptor.java
> index 9b1e8de61ef0f1c97fbb78b508d7fa467b3cf8c0..
> 6360ec43e7c3ae7539b6436493840034426f96e1 100644
> --- a/src/com/google/enterprise/adaptor/fs/FsAdaptor.java
> +++ b/src/com/google/enterprise/adaptor/fs/FsAdaptor.java
> @@ -184,7 +184,7 @@ public class FsAdaptor extends AbstractAdaptor
> implements
>
>    @Override
>    public void initConfig(Config config) {
> -    config.addKey(CONFIG_SRC, null);
> +    config.addKey(CONFIG_SRC, "");
>      config.addKey(CONFIG_SUPPORTED_ACCOUNTS,
>          "BUILTIN\\Administrators,Everyone,BUILTIN\\Users,BUILTIN\\Guest,"
>          + "NT AUTHORITY\\INTERACTIVE,NT AUTHORITY\\Authenticated Users");
>
>
>

[Brett, 2014-05-15 00:05:31]

Committed 14 May 2014 to Filesystem Adaptor:
To https://code.google.com/p/plexi.fs/
   e3f3d67..cc553af  master -> master

[ejona, 2014-06-09 22:10:13]

Init() wouldn't have been called if the property was not set. Maybe instead we
should have Config validation logic throw InvalidConfigurationException?