Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(208)

Issue 91118: Implement osx:Variable element, w/some refactoring

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 1 month ago by awiner
Modified:
10 years, 8 months ago
Reviewers:
levik, shindig.remailer
Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -2352 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloader.java View 3 chunks +43 lines, -15 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java View 1 chunk +4 lines, -4 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/PipelinedData.java View 12 chunks +162 lines, -123 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/AbstractTagHandler.java View 1 chunk +0 lines, -99 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/AbstractTagRegistry.java View 1 chunk +0 lines, -32 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/CompositeTagRegistry.java View 1 chunk +0 lines, -43 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTagRegistry.java View 1 chunk +0 lines, -45 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java View 1 chunk +2 lines, -0 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/ElementELResolver.java View 1 chunk +1 line, -1 line 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/FlashTagHandler.java View 1 chunk +0 lines, -420 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/HtmlTagHandler.java View 1 chunk +0 lines, -67 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/IfTagHandler.java View 1 chunk +0 lines, -45 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/NullTemplateLibrary.java View 1 chunk +2 lines, -0 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/RenderTagHandler.java View 1 chunk +0 lines, -81 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/RepeatTagHandler.java View 1 chunk +0 lines, -60 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TagHandler.java View 1 chunk +0 lines, -54 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TagRegistry.java View 1 chunk +2 lines, -0 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateBasedTagHandler.java View 1 chunk +0 lines, -118 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java View 3 chunks +14 lines, -2 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/XmlTemplateLibrary.java View 1 chunk +3 lines, -0 lines 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/AbstractTagHandler.java View 1 chunk +2 lines, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/AbstractTagRegistry.java View 1 chunk +2 lines, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/CompositeTagRegistry.java View 1 chunk +3 lines, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/DefaultTagRegistry.java View 1 chunk +1 line, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/FlashTagHandler.java View 2 chunks +2 lines, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/HtmlTagHandler.java View 1 chunk +2 lines, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/IfTagHandler.java View 1 chunk +2 lines, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/RenderTagHandler.java View 2 chunks +3 lines, -2 lines 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/RepeatTagHandler.java View 1 chunk +2 lines, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/TagHandler.java View 1 chunk +2 lines, -1 line 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandler.java View 2 chunks +3 lines, -2 lines 0 comments Download
A java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VariableTagHandler.java View 1 chunk +50 lines, -0 lines 1 comment Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelineExecutorTest.java View 4 chunks +18 lines, -8 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/preload/PipelinedDataPreloaderTest.java View 2 chunks +35 lines, -0 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/PipelineDataGadgetRewriterTest.java View 3 chunks +19 lines, -8 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/PipelinedDataTest.java View 11 chunks +66 lines, -33 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ViewTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/AbstractTagHandlerTest.java View 1 chunk +0 lines, -79 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/CompositeTagRegistryTest.java View 1 chunk +0 lines, -76 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTagRegistryTest.java View 1 chunk +0 lines, -71 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java View 1 chunk +3 lines, -0 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/FlashTagHandlerTest.java View 1 chunk +0 lines, -273 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/HtmlTagHandlerTest.java View 1 chunk +0 lines, -62 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/IfTagHandlerTest.java View 1 chunk +0 lines, -89 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/RenderTagHandlerTest.java View 1 chunk +0 lines, -135 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/RepeatTagHandlerTest.java View 1 chunk +0 lines, -100 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/TemplateBasedTagHandlerTest.java View 1 chunk +0 lines, -180 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/XmlTemplateLibraryTest.java View 1 chunk +1 line, -0 lines 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/AbstractTagHandlerTest.java View 2 chunks +3 lines, -1 line 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/CompositeTagRegistryTest.java View 1 chunk +7 lines, -1 line 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/DefaultTagRegistryTest.java View 1 chunk +6 lines, -1 line 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/FlashTagHandlerTest.java View 2 chunks +5 lines, -1 line 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/HtmlTagHandlerTest.java View 1 chunk +3 lines, -1 line 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/IfTagHandlerTest.java View 2 chunks +4 lines, -1 line 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/RenderTagHandlerTest.java View 2 chunks +9 lines, -1 line 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/RepeatTagHandlerTest.java View 1 chunk +4 lines, -1 line 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java View 2 chunks +9 lines, -1 line 0 comments Download
M java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java View 2 chunks +3 lines, -1 line 0 comments Download
M java/server/src/test/resources/endtoend/pipeliningTest.xml View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 2
awiner
This patch implements <osx:Variable> for both data pipelining and templating, as discussed on the opensocial ...
16 years, 1 month ago (2009-07-14 22:46:46 UTC) #1
levik
16 years, 1 month ago (2009-07-15 15:52:42 UTC) #2
This implementation seems to define the variable for the entire invocation scope
of a template (rather than scoped to the parent element of the <osx:Variable>
tag as was initially proposed on the discussion thread.

http://codereview.appspot.com/91118/diff/1/39
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VariableTagHandler.java
(right):

http://codereview.appspot.com/91118/diff/1/39#newcode48
Line 48: processor.getTemplateContext().getMy().put(key, value);
I think putting the variable into Cur is more appropriate than My, since My is
used to access XML attributes and Cur is used to access runtime data.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b