Issue 909042: review to allow custom OpenEXR libraries

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 909042: review to allow custom OpenEXR libraries (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by clifford.stein

Modified:
13 years, 3 months ago

Reviewers:
dev-osl, larrygritz, osl-dev

Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/

Visibility:
Public.

Description

This is similar to a patch I've submitted to OpenImageIO. I'll cut-n-paste the same patch description here: This review allows one to specify custom OpenEXR library names. This has come up here at SPI where we're using OpenEXR libraries with custom filenames in our new OS to avoid "collisions" with the system installed libraries. I've tested this on our two Linux platforms here at SPI -- one uses custom OpenEXR library filenames while the other does not.

Patch Set 1 #

Patch Set 2 : The previous patch was broken. This seems to do the trick. #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -9 lines)			Patch
		site/spi/Makefile-bits	View		1 chunk	+5 lines, -0 lines	0 comments	Download
		src/cmake/externalpackages.cmake	View	1	2 chunks	+29 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM.  Analogous to the change in OIIO for the same purpose.

Expand All Messages | Collapse All Messages