Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(184)

Issue 90470043: FSA Add Additional tests to WindowsFileDelegateTest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Brett
Modified:
9 years, 11 months ago
Reviewers:
pjo, mifern
CC:
myk, connector-cr_google.com
Visibility:
Public.

Description

This adds tests for WindowsFileDelegate.getDfsShareAclView() and WindowsFileDelegate.getDfsUncActiveStorageUnc() using JNA fakes to simulate the Netapi32Ex DFS calls. This brings the WindowsFileDelegate up to 88% coverage and the adaptor as a whole to 93% line coverage and 88% branch coverage.

Patch Set 1 #

Total comments: 14

Patch Set 2 : Miguel and PJ's feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -6 lines) Patch
M src/com/google/enterprise/adaptor/fs/WinApi.java View 2 chunks +6 lines, -0 lines 0 comments Download
M src/com/google/enterprise/adaptor/fs/WindowsFileDelegate.java View 1 1 chunk +1 line, -1 line 0 comments Download
M test/com/google/enterprise/adaptor/fs/TestWindowsAclViews.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java View 1 2 chunks +235 lines, -3 lines 1 comment Download

Messages

Total messages: 8
Brett
9 years, 11 months ago (2014-04-23 01:50:22 UTC) #1
mifern
https://codereview.appspot.com/90470043/diff/1/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java File test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java (right): https://codereview.appspot.com/90470043/diff/1/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java#newcode215 test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java:215: public void testGetDfsUncActiveStorageUncSingleActiveStorage() throws Exception { 80 chars https://codereview.appspot.com/90470043/diff/1/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java#newcode231 ...
9 years, 11 months ago (2014-04-23 17:15:45 UTC) #2
pjo
Thank you. LGTM. https://codereview.appspot.com/90470043/diff/1/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java File test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java (right): https://codereview.appspot.com/90470043/diff/1/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java#newcode142 test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java:142: private AclFileAttributeView getDfsShareAclView( make static https://codereview.appspot.com/90470043/diff/1/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java#newcode269 ...
9 years, 11 months ago (2014-04-23 17:59:36 UTC) #3
Brett
https://codereview.appspot.com/90470043/diff/1/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java File test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java (right): https://codereview.appspot.com/90470043/diff/1/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java#newcode142 test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java:142: private AclFileAttributeView getDfsShareAclView( On 2014/04/23 17:59:37, pjo wrote: > ...
9 years, 11 months ago (2014-04-23 18:22:27 UTC) #4
Brett
Miguel and PJ's feedback
9 years, 11 months ago (2014-04-23 18:24:55 UTC) #5
pjo
Thank you. Still LGTM. https://codereview.appspot.com/90470043/diff/20001/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java File test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java (right): https://codereview.appspot.com/90470043/diff/20001/test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java#newcode277 test/com/google/enterprise/adaptor/fs/WindowsFileDelegateTest.java:277: private static Path getDfsUncActiveStorageUnc(final Netapi32Ex.DFS_INFO_3 ...
9 years, 11 months ago (2014-04-23 18:29:54 UTC) #6
mifern
LGTM
9 years, 11 months ago (2014-04-23 19:19:30 UTC) #7
Brett
9 years, 11 months ago (2014-04-23 19:28:36 UTC) #8
Committed 23 April 2014 to File System Adaptor:
To https://code.google.com/p/plexi.fs/
   84e1977..0063de9  master -> master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b