Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2007)

Issue 904042: ns-3: Set FCS included flag in Radiotap frame header (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by Dean
Modified:
13 years, 11 months ago
Reviewers:
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This patch corrects a bug in the YansWifiHelper support for PCAP tracing with Radiotap data link format, which is tracked as Bug 875 in the ns-3 Bugzilla module. Specifically, in the current implementation the "Frame includes FCS" flag is not set, despite the FCS being present in the captured frames. The ns-3 patch (first patch set here) is based on ns-3-dev changeset 6191:5cde5bcbc902 With the proposed fix, the wifi-wired-bridging reference traces need updating (this test, which is run as part of the regression test set, appears to be the only one which uses Radiotap capture). The updates are here as the second patch set, which is based on ns-3-dev-ref-traces changeset 108:6da919120dfb

Patch Set 1 #

Patch Set 2 : Update for wifi-wired-bridging reference traces after ns-3 Bug 875 fix applied #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M wifi-wired-bridging.ref/wifi-wired-bridging-0-2.pcap View Binary file 0 comments Download
M wifi-wired-bridging.ref/wifi-wired-bridging-1-2.pcap View Binary file 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b