Fixed enum binding support (issue #49)

Fixes handling of inner enums and enums with custom logic.

[Aragos, 2009-07-02 04:07:12]

Let me know if I forgot a corner case! :)

Peter

[Brian_Stoler, 2009-07-02 04:16:03]

http://codereview.appspot.com/90085/diff/1/8
File src/com/google/gwt/inject/rebind/binding/BindConstantBinding.java (right):

http://codereview.appspot.com/90085/diff/1/8#newcode95
Line 95: className = className.substring(0, className.lastIndexOf("$"));
Can you just check if getEnclosingClass is non-null and use that if not?

[Aragos, 2009-07-02 20:34:57]

Thanks for taking a look so fast! :)

http://codereview.appspot.com/90085/diff/1/8
File src/com/google/gwt/inject/rebind/binding/BindConstantBinding.java (right):

http://codereview.appspot.com/90085/diff/1/8#newcode95
Line 95: className = className.substring(0, className.lastIndexOf("$"));
On 2009/07/02 04:16:03, Brian_Stoler wrote:
> Can you just check if getEnclosingClass is non-null and use that if not?

Using getEnclosingClass instead of substring. I can't use it on the matcher
because it would also match inner enums.