Issue 90085: Fixed enum binding support (issue #49)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 90085: Fixed enum binding support (issue #49) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 months, 2 weeks ago by Aragos

Modified:
4 months, 2 weeks ago

Reviewers:
Brian_Stoler

CC:
google-gin_googlegroups.com

SVN Base:
http://google-gin.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fixes handling of inner enums and enums with custom logic.

Patch Set 2 : Using getEnclosingClass

Created: 5 months, 2 weeks ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
src/com/google/gwt/inject/rebind/binding/BindConstantBinding.java	View	1	4 chunks	53 lines	0 comments	Download
test/com/google/gwt/inject/client/binding/Color.java	View		1 chunk	21 lines	0 comments	Download
test/com/google/gwt/inject/client/binding/ConstantBindingTest.java	View		1 chunk	15 lines	0 comments	Download
test/com/google/gwt/inject/client/binding/Fruit.java	View		1 chunk	39 lines	0 comments	Download
test/com/google/gwt/inject/client/binding/FruitGinModule.java	View		2 chunks	23 lines	0 comments	Download
test/com/google/gwt/inject/client/binding/FruitGinjector.java	View		1 chunk	12 lines	0 comments	Download
test/com/google/gwt/inject/rebind/binding/BindConstantBindingTest.java	View		6 chunks	101 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Brian_Stoler

http://codereview.appspot.com/90085/diff/1/8 File src/com/google/gwt/inject/rebind/binding/BindConstantBinding.java (right): http://codereview.appspot.com/90085/diff/1/8#newcode95 Line 95: className = className.substring(0, className.lastIndexOf("$")); Can you just check ...

5 months, 2 weeks ago

Aragos

Thanks for taking a look so fast! :) http://codereview.appspot.com/90085/diff/1/8 File src/com/google/gwt/inject/rebind/binding/BindConstantBinding.java (right): http://codereview.appspot.com/90085/diff/1/8#newcode95 Line 95: ...

5 months, 2 weeks ago

Thanks for taking a look so fast! :)

http://codereview.appspot.com/90085/diff/1/8
File src/com/google/gwt/inject/rebind/binding/BindConstantBinding.java (right):

http://codereview.appspot.com/90085/diff/1/8#newcode95
Line 95: className = className.substring(0, className.lastIndexOf("$"));
On 2009/07/02 04:16:03, Brian_Stoler wrote:
> Can you just check if getEnclosingClass is non-null and use that if not?

Using getEnclosingClass instead of substring. I can't use it on the matcher
because it would also match inner enums.

Expand All Messages | Collapse All Messages