Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 90085: Fixed enum binding support (issue #49) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by Aragos
Modified:
4 months, 2 weeks ago
Reviewers:
Brian_Stoler
CC:
google-gin_googlegroups.com
SVN Base:
http://google-gin.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixes handling of inner enums and enums with custom logic.

Patch Set 1

Total comments: 2

Patch Set 2 : Using getEnclosingClass

Messages

Total messages: 3
Aragos
Let me know if I forgot a corner case! :) Peter
5 months, 2 weeks ago
Brian_Stoler
http://codereview.appspot.com/90085/diff/1/8 File src/com/google/gwt/inject/rebind/binding/BindConstantBinding.java (right): http://codereview.appspot.com/90085/diff/1/8#newcode95 Line 95: className = className.substring(0, className.lastIndexOf("$")); Can you just check ...
5 months, 2 weeks ago
Aragos
5 months, 2 weeks ago
Thanks for taking a look so fast! :)

http://codereview.appspot.com/90085/diff/1/8
File src/com/google/gwt/inject/rebind/binding/BindConstantBinding.java (right):

http://codereview.appspot.com/90085/diff/1/8#newcode95
Line 95: className = className.substring(0, className.lastIndexOf("$"));
On 2009/07/02 04:16:03, Brian_Stoler wrote:
> Can you just check if getEnclosingClass is non-null and use that if not?

Using getEnclosingClass instead of substring. I can't use it on the matcher
because it would also match inner enums.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld r501