Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19158)

Issue 8971043: Doc: add snippet showing flared and constante hairpins (3235) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by Trevor Daniels
Modified:
10 years, 11 months ago
Reviewers:
Graham Percival, janek
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: add snippet showing flared and constante hairpins (3235) simply use Mike's regression test as the example code

Patch Set 1 #

Patch Set 2 : Correct upload #

Total comments: 1

Patch Set 3 : Use . syntax #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M Documentation/notation/expressive.itely View 1 chunk +10 lines, -0 lines 0 comments Download
A Documentation/snippets/new/printing-hairpins-in-various-styles.ly View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
A Documentation/snippets/printing-hairpins-in-various-styles.ly View 1 2 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Trevor Daniels
Correct upload
11 years ago (2013-04-26 10:58:24 UTC) #1
janek
one question. https://codereview.appspot.com/8971043/diff/2001/Documentation/snippets/printing-hairpins-in-various-styles.ly File Documentation/snippets/printing-hairpins-in-various-styles.ly (right): https://codereview.appspot.com/8971043/diff/2001/Documentation/snippets/printing-hairpins-in-various-styles.ly#newcode22 Documentation/snippets/printing-hairpins-in-various-styles.ly:22: \override Hairpin #'stencil = #flared-hairpin Shouldn't we ...
10 years, 11 months ago (2013-05-09 04:33:17 UTC) #2
Trevor Daniels
On 2013/05/09 04:33:17, janek wrote: > one question. > > https://codereview.appspot.com/8971043/diff/2001/Documentation/snippets/printing-hairpins-in-various-styles.ly > File Documentation/snippets/printing-hairpins-in-various-styles.ly (right): ...
10 years, 11 months ago (2013-05-09 08:06:29 UTC) #3
Trevor Daniels
Use . syntax
10 years, 11 months ago (2013-05-09 08:10:49 UTC) #4
janek
thanks! LGTM 2013/5/9 <tdanielsmusic@googlemail.com>: > On 2013/05/09 04:33:17, janek wrote: >> >> one question. > ...
10 years, 11 months ago (2013-05-09 09:26:14 UTC) #5
Graham Percival
LGTM, and I really like that . syntax.
10 years, 11 months ago (2013-05-10 23:43:56 UTC) #6
Trevor Daniels
10 years, 11 months ago (2013-05-13 09:00:56 UTC) #7
Pushed to staging as
9e42345b99c9f663f8647513ec2caa8c64dccf6a
Closing ...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b