Issue 895041: Review: bug fixes related to deriv changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 895041: Review: bug fixes related to deriv changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by larrygritz

Modified:
14 years ago

Reviewers:
ckulla

Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Missed a couple: * Two spots where we asked the renderer for stuff and asked for derivs anytime it was float-based, instead of when the destination symbol had them. * Always mark P as needing derivs if it's written in a shader, we need that for displacement to work right. * Fix a bad ASSERT in aref constant folding (too restrictive, since we allow constants to be strings and matrices these days too).

Patch Set 1 #

Patch Set 2 : Per offline discussion: make ALL globals written by the shader provide derivs #

Patch Set 3 : Oops, uploaded wrong diff last time. This one is right. #

Created: 14 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
src/liboslexec/exec.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
src/liboslexec/opattribute.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download
src/liboslexec/runtimeoptimize.cpp	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

larrygritz

Per offline discussion: make ALL globals written by the shader provide derivs

14 years ago (2010-04-06 17:40:10 UTC) #3

Oops, uploaded wrong diff last time.  This one is right.

Expand All Messages | Collapse All Messages