Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 89083: Start the appengine-tools gem (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by ribrdb
Modified:
3 months, 1 week ago
Reviewers:
woodie
CC:
SVN Base:
http://appengine-jruby.googlecode.com/svn/trunk/appengine-tools/
Visibility:
Public.

Patch Set 1

Patch Set 2 : Some cleanups to follow the style guide.

Total comments: 10

Patch Set 3 : Clean up xml formatting.

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
A LICENSE View 1 chunk 208 lines 0 comments Download
A README.rdoc View 1 2 1 chunk 16 lines 0 comments Download
A Rakefile View 1 1 chunk 59 lines 0 comments Download
A lib/appengine-tools/genxml.rb View 1 2 1 chunk 40 lines 0 comments Download
A lib/appengine-tools/rack.rb View 1 2 1 chunk 161 lines 3 comments Download
A lib/appengine-tools/web-xml.rb View 1 2 1 chunk 149 lines 1 comment Download
A lib/appengine-tools/xml-formatter.rb View 1 chunk 45 lines 0 comments Download

Messages

Total messages: 6
ribrdb
4 months, 1 week ago
woodie
I need to get a current copy working http://codereview.appspot.com/89083/diff/1008/10 File README.rdoc (right): http://codereview.appspot.com/89083/diff/1008/10#newcode2 Line 2: ...
4 months, 1 week ago
woodie
If you want to call a method that returns nicely formatted XML, and also have ...
4 months, 1 week ago
ribrdb
http://codereview.appspot.com/89083/diff/1008/10 File README.rdoc (right): http://codereview.appspot.com/89083/diff/1008/10#newcode2 Line 2: On 2009/07/02 03:33:09, mando.woodie wrote: > Generate XML ...
4 months, 1 week ago
woodie
If the resource classes were useful outside this application it could be helpful to flip ...
4 months, 1 week ago
woodie
4 months, 1 week ago
I need to figure out how to send diffs

http://codereview.appspot.com/89083/diff/3001/2005
File lib/appengine-tools/rack.rb (right):

http://codereview.appspot.com/89083/diff/3001/2005#newcode75
Line 75: class RackApplication
# I liked my force-to-string mod, but with your way
# you should only generate the reader for :version 

      attr_accessor :application
      attr_reader :version, :static_files, :resource_files
      attr_reader :system_properties, :environment_variables
      attr_writer :ssl_enabled, :sessions_enabled
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld r483