Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9461)

Issue 8853044: Doc: Change \on-the-fly #procedure to \on-the-fly \procedure (3098) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by Trevor Daniels
Modified:
11 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Change \on-the-fly #procedure to \on-the-fly \procedure (3098) This avoids problems when \on-the-fly is used within #{ .. #}

Patch Set 1 #

Patch Set 2 : Extend description of LilyPond code blocks #

Total comments: 8

Patch Set 3 : Respond to Ian's comments; fix spelling of LilyPond throughout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -50 lines) Patch
M Documentation/extending/programming-interface.itely View 1 2 9 chunks +82 lines, -44 lines 0 comments Download
M Documentation/notation/input.itely View 4 chunks +5 lines, -5 lines 0 comments Download
M ly/titling-init.ly View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
Trevor Daniels
I'll add the change to EM 2.1 as part of Patch Set 2 shortly
11 years ago (2013-04-18 13:45:34 UTC) #1
Trevor Daniels
Extend description of LilyPond code blocks
11 years ago (2013-04-18 22:51:02 UTC) #2
Trevor Daniels
Ready for testing and review now. https://codereview.appspot.com/8853044/diff/3001/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/8853044/diff/3001/Documentation/extending/programming-interface.itely#newcode1318 Documentation/extending/programming-interface.itely:1318: @code{\overrideProper ty} function, ...
11 years ago (2013-04-18 22:57:20 UTC) #3
Ian Hulin (gmail)
LGTM (including your local correction). Add some new index entries for concepts discussed in this ...
11 years ago (2013-04-19 00:33:39 UTC) #4
Trevor Daniels
Thanks Ian https://codereview.appspot.com/8853044/diff/3001/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/8853044/diff/3001/Documentation/extending/programming-interface.itely#newcode34 Documentation/extending/programming-interface.itely:34: On 2013/04/19 00:33:39, Ian Hulin (gmail) wrote: ...
11 years ago (2013-04-19 07:30:47 UTC) #5
Trevor Daniels
Respond to Ian's comments; fix spelling of LilyPond throughout
11 years ago (2013-04-19 07:37:27 UTC) #6
Graham Percival
LGTM
11 years ago (2013-04-21 08:37:43 UTC) #7
janek
LGTM
11 years ago (2013-04-23 13:23:54 UTC) #8
Trevor Daniels
11 years ago (2013-04-24 07:48:33 UTC) #9
Pushed to staging as
09f7d25964ec1ae3ad1f4a862a2b46444f56c50f
and
ecc41fd08c437396edb27d1fb82c977e7404803e
Closing ...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b