Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(428)

Issue 885044: Fix #786. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by Neil Puttock
Modified:
14 years ago
Reviewers:
Trevor Daniels
CC:
Visibility:
Public.

Description

Fix #786. Send a CompletizeExtenderEvent at the end of each lyrics block so that the Extender_engraver can tie up loose ends with any pending extender. * input/regression (display-lily-tests.ly): add extra space to \lyricsto and \addlyrics test to account for silenced display method * lily/extender-engraver.cc: add listener for CompletizeExtenderEvent which will call completize_extender () if necessary revert previous fix which checked for empty LyricText grob * lily/hyphen-engraver.cc: revert fix as above * lily/lyric-engraver.cc (process_music): don't create empty LyricText grobs * scm/define-event-classes.scm (event-classes): add completize-extender-event as child of music-event * scm/define-music-display-methods.scm: add display method for CompletizeExtenderEvent (returns empty string) * scm/define-music-types.scm (music-descriptions): add CompletizeExtenderEvent * scm/ly-syntax-constructors.scm (lyric-combine-music): insert CompletizeExtenderEvent at the end of the sequential music (i.e., following the last lyric)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix typo in \version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M input/regression/display-lily-tests.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lily/extender-engraver.cc View 8 chunks +27 lines, -34 lines 0 comments Download
M lily/hyphen-engraver.cc View 5 chunks +7 lines, -11 lines 0 comments Download
M lily/lyric-engraver.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M scm/define-event-classes.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-music-display-methods.scm View 1 chunk +3 lines, -1 line 0 comments Download
M scm/define-music-types.scm View 1 chunk +7 lines, -0 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Neil Puttock
Hi, This patch implements the suggestion outlined here: http://lists.gnu.org/archive/html/lilypond-devel/2010-01/msg00120.html Please review. Thanks, Neil
14 years, 1 month ago (2010-04-05 23:59:09 UTC) #1
Trevor Daniels
Typo http://codereview.appspot.com/885044/diff/1/2 File input/regression/display-lily-tests.ly (right): http://codereview.appspot.com/885044/diff/1/2#newcode1 input/regression/display-lily-tests.ly:1: \version "2.13.8" 2.13.18
14 years, 1 month ago (2010-04-06 08:13:20 UTC) #2
Neil Puttock
14 years, 1 month ago (2010-04-07 22:37:20 UTC) #3
On 2010/04/06 08:13:20, Trevor Daniels wrote:
> Typo
> 
> http://codereview.appspot.com/885044/diff/1/2
> File input/regression/display-lily-tests.ly (right):
> 
> http://codereview.appspot.com/885044/diff/1/2#newcode1
> input/regression/display-lily-tests.ly:1: \version "2.13.8"
> 2.13.18

Done.

Thanks for checking, Trevor.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b