Added GYP build files. GYP files are needed for integration with chromium and...

Added GYP build files. GYP files are needed for integration with chromium and cross-platform build for glsl translator. It would really be nice if we did not have to maintain two build systems. For now I have only moved the GLSL translator to gyp build system. Please note that the gyp files awkwardly have build_ prefix so they do not conflict with the manually-maintained sln files.

[Alok Priyadarshi, 2010-04-05 15:43:26]

Grammar files needed to be changed so that they can be parsed by newer versions
of flex and bison.

[kbr1, 2010-04-05 19:42:22]

LGTM

[kbr1, 2010-04-05 19:42:32]

http://codereview.appspot.com/885043/diff/1/4
File build/all.gyp (right):

http://codereview.appspot.com/885043/diff/1/4#newcode11
build/all.gyp:11: # build_ prefix should be removed from the gyp files as soon
as we can
This comment should be prefixed with TODO(alokp).

[dgkoch, 2010-04-05 20:29:11]

Do these grammer changes continue to work with the old flex and bison that are
in compiler/tools?  The main reason we haven't switched to newer versions of
flex and bison is to avoid another external project dependency.  The newer
windows versions of these tools would likely need to be made an external Visual
Studio dependency since they are no longer nice and standalone executables like
the present versions are.

Also WRT switching exclusively to GYP.  We are not at all familiar with this
tool.  Can you provide more information? Is this something that we (TransGaming
and anyone else external) can use as well?  I'm a bit hesitant to switch to this
exclusively for this project due to concerns that this will raise the bar for
other people who might want to participate in the project as well.

[Alok Priyadarshi, 2010-04-05 20:57:39]

Hi Daniel,

The grammar changes are solely made so they continue to work with the old flex
and bison exes. I have ran hlsl translator on a couple of shaders and they seem
to be working fine. In the new GYP build I am using flex and bison under cygwin.

It is pretty easy to switch to GYP. The only extra dependency is depot_tools
which is a set of python utilities to maintain multiple svn repositories. You
can set it up by following the instructions here:
http://www.chromium.org/developers/how-tos/install-gclient

After you have depot_tools in your path, do the following to setup your client:
1. Create a directory to hold your source code. This example assumes
c:\angleproject, but other names are fine. Important: Make sure the full
directory path has no spaces.
2. In a shell window, execute the following commands:
    cd c:\angleproject
    gclient config https://angleproject.googlecode.com/svn/trunk/

To checkout or update code, execute the following commands:
    cd c:\angleproject
    gclient sync

The sync command gets/updates the source code in the trunk and other
repositories specified in DEPS file (added in this CL). It also generates build
files at the end. I think it will be nice to just use one build system. We HAVE
to use GYP to integrate with chromium, and it is also nice for cross-platform
builds. If you guys are willing to switch, I will be happy to maintain the gyp
build system.

[dgkoch, 2010-04-06 15:14:21]

Hi Alok,

Thanks for verifying that the grammars still work with the existing flex and
bison.

I have no problems with you adding the files for GYP support that if that is
necessary for Chromium integration. It looks interesting (although sparsely
documented) and I'm looking forward to trying it out once it's in place and I
can experiment with it directly.  However, at this point I can't commit to us
switching to GYP until we've had a chance to investigate further. The fact that
we're using an internal git repository for our code will likely make this more
complicated.  Would it simplify integration for you if we renamed the solution
files that we are currently using?

Does GYP generate the .vcproj files as well, or just the .sln files?  

If you like, we can continue to discuss this further offline.  As is, this patch
set looks good to me.

Thanks,
Daniel

On 2010/04/05 20:57:39, alokp wrote:
> Hi Daniel,
> 
> The grammar changes are solely made so they continue to work with the old flex
> and bison exes. I have ran hlsl translator on a couple of shaders and they
seem
> to be working fine. In the new GYP build I am using flex and bison under
cygwin.
> 
> It is pretty easy to switch to GYP. The only extra dependency is depot_tools
> which is a set of python utilities to maintain multiple svn repositories. You
> can set it up by following the instructions here:
> http://www.chromium.org/developers/how-tos/install-gclient
> 
> After you have depot_tools in your path, do the following to setup your
client:
> 1. Create a directory to hold your source code. This example assumes
> c:\angleproject, but other names are fine. Important: Make sure the full
> directory path has no spaces.
> 2. In a shell window, execute the following commands:
>     cd c:\angleproject
>     gclient config https://angleproject.googlecode.com/svn/trunk/
> 
> To checkout or update code, execute the following commands:
>     cd c:\angleproject
>     gclient sync
> 
> The sync command gets/updates the source code in the trunk and other
> repositories specified in DEPS file (added in this CL). It also generates
build
> files at the end. I think it will be nice to just use one build system. We
HAVE
> to use GYP to integrate with chromium, and it is also nice for cross-platform
> builds. If you guys are willing to switch, I will be happy to maintain the gyp
> build system.

[Alok Priyadarshi, 2010-04-06 15:41:05]

I am not a git expert but a few people on the chromium project use git
with GYP. Basically you just need to execute the python script in
gyp_angle to generate build files.

GYP generates .vcproj as well. It also supports visual studio express.

In the next CL, I will also add libEGL and libGLES2 so you can start
experimenting and see if it works for you.

On Tue, Apr 6, 2010 at 9:14 AM,  <daniel@transgaming.com> wrote:
> Hi Alok,
>
> Thanks for verifying that the grammars still work with the existing flex
> and bison.
>
> I have no problems with you adding the files for GYP support that if
> that is necessary for Chromium integration. It looks interesting
> (although sparsely documented) and I'm looking forward to trying it out
> once it's in place and I can experiment with it directly.  However, at
> this point I can't commit to us switching to GYP until we've had a
> chance to investigate further. The fact that we're using an internal git
> repository for our code will likely make this more complicated.  Would
> it simplify integration for you if we renamed the solution files that we
> are currently using?
>
> Does GYP generate the .vcproj files as well, or just the .sln files?
>
> If you like, we can continue to discuss this further offline.  As is,
> this patch set looks good to me.
>
> Thanks,
> Daniel
>
> On 2010/04/05 20:57:39, alokp wrote:
>>
>> Hi Daniel,
>
>> The grammar changes are solely made so they continue to work with the
>
> old flex
>>
>> and bison exes. I have ran hlsl translator on a couple of shaders and
>
> they seem
>>
>> to be working fine. In the new GYP build I am using flex and bison
>
> under cygwin.
>
>> It is pretty easy to switch to GYP. The only extra dependency is
>
> depot_tools
>>
>> which is a set of python utilities to maintain multiple svn
>
> repositories. You
>>
>> can set it up by following the instructions here:
>> http://www.chromium.org/developers/how-tos/install-gclient
>
>> After you have depot_tools in your path, do the following to setup
>
> your client:
>>
>> 1. Create a directory to hold your source code. This example assumes
>> c:\angleproject, but other names are fine. Important: Make sure the
>
> full
>>
>> directory path has no spaces.
>> 2. In a shell window, execute the following commands:
>>     cd c:\angleproject
>>     gclient config https://angleproject.googlecode.com/svn/trunk/
>
>> To checkout or update code, execute the following commands:
>>     cd c:\angleproject
>>     gclient sync
>
>> The sync command gets/updates the source code in the trunk and other
>> repositories specified in DEPS file (added in this CL). It also
>
> generates build
>>
>> files at the end. I think it will be nice to just use one build
>
> system. We HAVE
>>
>> to use GYP to integrate with chromium, and it is also nice for
>
> cross-platform
>>
>> builds. If you guys are willing to switch, I will be happy to maintain
>
> the gyp
>>
>> build system.
>
>
>
> http://codereview.appspot.com/885043/show
>