Issue 8849: Set percent counter visibility using repeatCountVisibility.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8849: Set percent counter visibility using repeatCountVisibility. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by Neil Puttock

Modified:
14 years, 9 months ago

Reviewers:
hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Set percent counter visibility using repeatCountVisibility.

Patch Set 2 : Add context argument to procedure call. #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -6 lines)			Patch
A	input/regression/repeat-percent-count-visibility.ly	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	lily/percent-repeat-engraver.cc	View	1	7 chunks	+17 lines, -6 lines	0 comments	Download
M	ly/engraver-init.ly	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	scm/define-context-properties.scm	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	scm/output-lib.scm	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

hanwenn

LGTM http://codereview.appspot.com/8849/diff/1/3 File lily/percent-repeat-engraver.cc (right): http://codereview.appspot.com/8849/diff/1/3#newcode228 Line 228: return (ly_is_procedure (proc) && to_boolean (scm_call_1 (proc, ...

15 years, 5 months ago (2008-11-14 01:51:20 UTC) #1

Neil Puttock

15 years, 5 months ago (2008-11-14 17:34:43 UTC) #2

On 2008/11/14 01:51:20, hanwenn wrote:

> http://codereview.appspot.com/8849/diff/1/3#newcode228
> Line 228: return (ly_is_procedure (proc) && to_boolean (scm_call_1 (proc,
> count)));
> add a context argument too, so the function can look around on its own if it
> needs to.

Done.

What about barNumberVisibility?  Would it be useful to have a context arg for
this too?

Expand All Messages | Collapse All Messages