Adds padding around extender of line-spanners.

Adds padding around extender of line-spanners.

Fixes PS backend to not print the lines that result in this padding.

[MikeSol, 2013-04-17 05:45:53]

Same as before

[MikeSol, 2013-04-17 10:33:20]

Fixes varios brainos

[Keith, 2013-04-20 05:06:08]

https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc
File lily/line-spanner.cc (right):

https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode371
lily/line-spanner.cc:371: // actual stencil bounds may be different
The actual stencil bounds are (inf , -inf) if someone sets style=none
When I try this on input/regression/dynamics-alignment-no-line.ly the while loop
in add_grobs_of_one_priority() takes forever.

https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode377
lily/line-spanner.cc:377: Real new_left_y = minmax (-d, extremity,
line_left[Y_AXIS] + d * skyline_spanner_padding);
The smaller of the extent of the cresc.--- and the line padded by
skyline_spanner_padding.  Is that what you want?

[mike7, 2013-04-20 07:25:43]

On 20 avr. 2013, at 08:06, k-ohara5a5a@oco.net wrote:

> 
> https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc
> File lily/line-spanner.cc (right):
> 
>
https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode371
> lily/line-spanner.cc:371: // actual stencil bounds may be different
> The actual stencil bounds are (inf , -inf) if someone sets style=none
> When I try this on input/regression/dynamics-alignment-no-line.ly the
> while loop in add_grobs_of_one_priority() takes forever.
> 
>
https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode377
> lily/line-spanner.cc:377: Real new_left_y = minmax (-d, extremity,
> line_left[Y_AXIS] + d * skyline_spanner_padding);
> The smaller of the extent of the cresc.--- and the line padded by
> skyline_spanner_padding.  Is that what you want?
> 

Yeah, because we never want the padding going outside of the grob.

Cheers,
MS

[MikeSol, 2013-04-20 07:27:12]

Doesn't draw extender padding for empty X extents

[dak, 2013-04-20 07:50:15]

"mike@mikesolomon.org" <mike@mikesolomon.org> writes:

> On 20 avr. 2013, at 08:06, k-ohara5a5a@oco.net wrote:
>
>> 
>> https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc
>> File lily/line-spanner.cc (right):
>> 
>>
https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode371
>> lily/line-spanner.cc:371: // actual stencil bounds may be different
>> The actual stencil bounds are (inf , -inf) if someone sets style=none
>> When I try this on input/regression/dynamics-alignment-no-line.ly the
>> while loop in add_grobs_of_one_priority() takes forever.
>> 
>>
https://codereview.appspot.com/8819043/diff/5001/lily/line-spanner.cc#newcode377
>> lily/line-spanner.cc:377: Real new_left_y = minmax (-d, extremity,
>> line_left[Y_AXIS] + d * skyline_spanner_padding);
>> The smaller of the extent of the cresc.--- and the line padded by
>> skyline_spanner_padding.  Is that what you want?
>> 
>
> Yeah, because we never want the padding going outside of the grob.
>
> Cheers,

Three cheers for a comment line.

-- 
David Kastrup

[Keith, 2013-04-20 08:09:42]

Remove the commented setting of minimum-Y-extent in scm/define-grobs.scm at the
same time, because it no longer works and you are replacing it.

https://codereview.appspot.com/8819043/diff/12001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

https://codereview.appspot.com/8819043/diff/12001/scm/define-grob-properties....
scm/define-grob-properties.scm:821: of a line spanner in its skylines.")
...; this padding being limited to stay within the extent of the entire spanner,
thus typically limited to the height of the text portion.

[MikeSol, 2013-04-23 06:06:03]

Better docstring, removes unused properties.