Issue 88151: added AthstatsWifiTraceSink and associated helper

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 88151: added AthstatsWifiTraceSink and associated helper (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Nicola Baldo

Modified:
14 years, 1 month ago

Reviewers:
Tom Henderson, Pavel Boyko

CC:
ns-3-reviews_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+473 lines, -0 lines)			Patch
M	examples/wifi-ap.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
A	src/devices/wifi/athstats-wifi-trace-sink.h	View	1 chunk	+80 lines, -0 lines	2 comments	Download
A	src/devices/wifi/athstats-wifi-trace-sink.cc	View	1 chunk	+218 lines, -0 lines	0 comments	Download
M	src/devices/wifi/wscript	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	src/helper/athstats-helper.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
A	src/helper/athstats-helper.cc	View	1 chunk	+106 lines, -0 lines	0 comments	Download
M	src/helper/wscript	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Pavel Boyko

Implementation looks very good, the only issue is to add more comments. Thank you. http://codereview.appspot.com/88151/diff/1/4 ...

14 years, 9 months ago (2009-07-10 15:08:23 UTC) #1

Tom Henderson

14 years, 9 months ago (2009-07-16 13:21:13 UTC) #2

I reviewed this today and think it will be a nice addition.  +1 for merging this
feature after Mathieu's implementation comments and Pavel's doxygen comments are
resolved.

http://codereview.appspot.com/88151/diff/1/4
File src/devices/wifi/athstats-wifi-trace-sink.h (right):

http://codereview.appspot.com/88151/diff/1/4#newcode21
Line 21: 
I reviewed this today and think it will be a nice addition.  +1 for merging this
feature after Mathieu's implementation comments and Pavel's doxygen comments are
resolved.

Expand All Messages | Collapse All Messages